Skip to content

Commit f285ccc

Browse files
committed
LocalIP: consider preferred source address when retrieving default route
1 parent e753d4d commit f285ccc

7 files changed

Lines changed: 207 additions & 24 deletions

File tree

src/common/netif/netif.c

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,18 @@
77
#include <iphlpapi.h>
88
#endif
99

10-
bool ffNetifGetDefaultRouteImpl(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex);
10+
bool ffNetifGetDefaultRouteImpl(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex, uint32_t* preferredSourceAddr);
1111
enum { IF_INDEX_UNINITIALIZED = (uint32_t) -1, IF_INDEX_INVALID = (uint32_t) -2 };
1212
static uint32_t ifIndex = IF_INDEX_UNINITIALIZED;
1313
static char ifName[IF_NAMESIZE + 1];
14+
static uint32_t preferredSourceAddr = 0;
1415

1516
static inline void init()
1617
{
17-
if (ifIndex == (uint32_t) IF_INDEX_UNINITIALIZED && !ffNetifGetDefaultRouteImpl(ifName, &ifIndex))
18-
ifIndex = (uint32_t) IF_INDEX_INVALID;
18+
if (ifIndex == (uint32_t) IF_INDEX_UNINITIALIZED) {
19+
if (!ffNetifGetDefaultRouteImpl(ifName, &ifIndex, &preferredSourceAddr))
20+
ifIndex = (uint32_t) IF_INDEX_INVALID;
21+
}
1922
}
2023

2124
const char* ffNetifGetDefaultRouteIfName()
@@ -29,3 +32,9 @@ uint32_t ffNetifGetDefaultRouteIfIndex()
2932
init();
3033
return ifIndex;
3134
}
35+
36+
uint32_t ffNetifGetDefaultRoutePreferredSourceAddr()
37+
{
38+
init();
39+
return preferredSourceAddr;
40+
}

src/common/netif/netif.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@
44

55
const char* ffNetifGetDefaultRouteIfName();
66
uint32_t ffNetifGetDefaultRouteIfIndex();
7+
uint32_t ffNetifGetDefaultRoutePreferredSourceAddr();

src/common/netif/netif_bsd.c

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ get_rt_address(struct rt_msghdr *rtm, int desired)
5050
return NULL;
5151
}
5252

53-
bool ffNetifGetDefaultRouteImpl(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex)
53+
bool ffNetifGetDefaultRouteImpl(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex, uint32_t* preferredSourceAddr)
5454
{
5555
#if defined(__OpenBSD__) || defined(__DragonFly__)
5656
int mib[6] = {CTL_NET, PF_ROUTE, 0, AF_INET, NET_RT_FLAGS, RTF_GATEWAY};
@@ -80,6 +80,12 @@ bool ffNetifGetDefaultRouteImpl(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex)
8080
memcpy(iface, sdl->sdl_data, sdl->sdl_nlen);
8181
iface[sdl->sdl_nlen] = '\0';
8282
*ifIndex = sdl->sdl_index;
83+
84+
// Get the preferred source address
85+
struct sockaddr_in* src = (struct sockaddr_in*)get_rt_address(rtm, RTA_IFA);
86+
if (preferredSourceAddr && src && src->sin_family == AF_INET)
87+
*preferredSourceAddr = src->sin_addr;
88+
8389
return true;
8490
}
8591
}
@@ -108,7 +114,7 @@ bool ffNetifGetDefaultRouteImpl(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex)
108114
.rtm_type = RTM_GET,
109115
.rtm_flags = RTF_UP | RTF_GATEWAY,
110116
.rtm_version = RTM_VERSION,
111-
.rtm_addrs = RTA_DST | RTA_IFP,
117+
.rtm_addrs = RTA_DST | RTA_IFP | RTA_IFA,
112118
.rtm_msglen = sizeof(rtmsg.hdr) + sizeof(rtmsg.dst),
113119
.rtm_pid = pid,
114120
.rtm_seq = 1,
@@ -139,6 +145,12 @@ bool ffNetifGetDefaultRouteImpl(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex)
139145
memcpy(iface, sdl->sdl_data, sdl->sdl_nlen);
140146
iface[sdl->sdl_nlen] = '\0';
141147
*ifIndex = sdl->sdl_index;
148+
149+
// Get the preferred source address
150+
struct sockaddr_in* src = (struct sockaddr_in*)get_rt_address(&rtmsg.hdr, RTA_IFA);
151+
if (preferredSourceAddr && src && src->sin_family == AF_INET)
152+
*preferredSourceAddr = src->sin_addr;
153+
142154
return true;
143155
}
144156
return false;

src/common/netif/netif_haiku.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
// loosely based on Haiku's src/bin/network/route/route.cpp
1313

14-
bool ffNetifGetDefaultRouteImpl(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex)
14+
bool ffNetifGetDefaultRouteImpl(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex, uint32_t* preferredSourceAddr)
1515
{
1616
// TODO: AF_INET6
1717
FF_AUTO_CLOSE_FD int pfRoute = socket(AF_INET, SOCK_RAW, AF_INET);

src/common/netif/netif_linux.c

Lines changed: 168 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,182 @@
11
#include "netif.h"
22
#include "common/io/io.h"
33

4+
#include <arpa/inet.h>
5+
#include <linux/rtnetlink.h>
46
#include <net/if.h>
5-
#include <stdio.h>
67

78
#define FF_STR_INDIR(x) #x
89
#define FF_STR(x) FF_STR_INDIR(x)
910

10-
static bool getDefaultRouteIPv4(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex)
11+
struct req_t {
12+
struct nlmsghdr nlh;
13+
struct rtmsg rtm;
14+
struct rtattr rta;
15+
uint32_t table;
16+
};
17+
18+
struct Route4Entry {
19+
uint32_t dest;
20+
uint32_t gateway;
21+
uint32_t src;
22+
uint8_t prefix_length;
23+
uint32_t metric;
24+
uint32_t ifindex;
25+
};
26+
27+
static bool getDefaultRouteIPv4(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex, uint32_t* preferredSourceAddr)
1128
{
12-
FILE* FF_AUTO_CLOSE_FILE netRoute = fopen("/proc/net/route", "r");
13-
if (!netRoute) return false;
29+
int sock_fd = socket(AF_NETLINK, SOCK_RAW | SOCK_CLOEXEC, NETLINK_ROUTE);
30+
if (sock_fd < 0)
31+
return false;
1432

15-
// skip first line
16-
FF_UNUSED(fscanf(netRoute, "%*[^\n]\n"));
33+
// Bind socket
34+
struct sockaddr_nl addr;
35+
memset(&addr, 0, sizeof(addr));
36+
addr.nl_family = AF_NETLINK;
37+
addr.nl_pid = 0; // Let kernel assign PID
38+
addr.nl_groups = 0;
1739

18-
unsigned long long destination; //, gateway, flags, refCount, use, metric, mask, mtu, ...
19-
while (fscanf(netRoute, "%" FF_STR(IF_NAMESIZE) "s%llx%*[^\n]", iface, &destination) == 2)
20-
{
21-
if (destination != 0) continue;
22-
*ifIndex = if_nametoindex(iface);
40+
if (bind(sock_fd, (struct sockaddr*)&addr, sizeof(addr)) < 0) {
41+
close(sock_fd);
42+
return false;
43+
}
44+
45+
struct req_t req;
46+
memset(&req, 0, sizeof(req));
47+
48+
// Netlink message header
49+
req.nlh.nlmsg_len = sizeof(req);
50+
req.nlh.nlmsg_type = RTM_GETROUTE;
51+
req.nlh.nlmsg_flags = NLM_F_REQUEST | NLM_F_DUMP;
52+
req.nlh.nlmsg_seq = 0;
53+
req.nlh.nlmsg_pid = 0;
54+
55+
// Route message
56+
req.rtm.rtm_family = AF_INET;
57+
req.rtm.rtm_dst_len = 0;
58+
req.rtm.rtm_src_len = 0;
59+
req.rtm.rtm_tos = 0;
60+
req.rtm.rtm_table = RT_TABLE_UNSPEC;
61+
req.rtm.rtm_protocol = RTPROT_UNSPEC;
62+
req.rtm.rtm_scope = RT_SCOPE_UNIVERSE;
63+
req.rtm.rtm_type = RTN_UNSPEC;
64+
req.rtm.rtm_flags = 0;
65+
66+
// Route attribute for main table
67+
req.rta.rta_len = RTA_LENGTH(sizeof(uint32_t));
68+
req.rta.rta_type = RTA_TABLE;
69+
req.table = RT_TABLE_MAIN;
70+
71+
struct sockaddr_nl dest_addr;
72+
memset(&dest_addr, 0, sizeof(dest_addr));
73+
dest_addr.nl_family = AF_NETLINK;
74+
dest_addr.nl_pid = 0;
75+
dest_addr.nl_groups = 0;
76+
77+
ssize_t sent = sendto(sock_fd, &req, sizeof(req), 0,
78+
(struct sockaddr*)&dest_addr, sizeof(dest_addr));
79+
80+
if (sent != sizeof(req)) {
81+
close(sock_fd);
82+
return false;
83+
}
84+
85+
struct sockaddr_nl src_addr;
86+
socklen_t src_addr_len = sizeof(src_addr);
87+
struct iovec iov = {NULL, 0};
88+
struct msghdr msg;
89+
90+
memset(&msg, 0, sizeof(msg));
91+
msg.msg_name = &src_addr;
92+
msg.msg_namelen = sizeof(src_addr);
93+
msg.msg_iov = &iov;
94+
msg.msg_iovlen = 1;
95+
96+
ssize_t peek_size = recvmsg(sock_fd, &msg, MSG_PEEK | MSG_TRUNC);
97+
if (peek_size < 0) {
98+
close(sock_fd);
99+
return false;
100+
}
101+
102+
uint8_t *buffer = malloc((size_t)peek_size);
103+
104+
ssize_t received = recvfrom(sock_fd, buffer, (size_t)peek_size, 0,
105+
(struct sockaddr*)&src_addr, &src_addr_len);
106+
107+
close(sock_fd);
108+
109+
struct Route4Entry best_gw;
110+
memset(&best_gw, 0, sizeof(best_gw));
111+
112+
for (const struct nlmsghdr* nlh = (struct nlmsghdr*)buffer;
113+
NLMSG_OK(nlh, received);
114+
nlh = NLMSG_NEXT(nlh, received)) {
115+
116+
if (nlh->nlmsg_type == NLMSG_DONE)
117+
break;
118+
119+
if (nlh->nlmsg_type != RTM_NEWROUTE)
120+
continue;
121+
122+
struct rtmsg* rtm = (struct rtmsg*)NLMSG_DATA(nlh);
123+
if (rtm->rtm_family != AF_INET)
124+
continue;
125+
126+
struct Route4Entry entry;
127+
memset(&entry, 0, sizeof(struct Route4Entry));
128+
entry.prefix_length = rtm->rtm_dst_len;
129+
130+
// Parse route attributes
131+
uint64_t rtm_len = RTM_PAYLOAD(nlh);
132+
for (struct rtattr* rta = RTM_RTA(rtm);
133+
RTA_OK(rta, rtm_len);
134+
rta = RTA_NEXT(rta, rtm_len)) {
135+
136+
switch (rta->rta_type) {
137+
case RTA_DST:
138+
entry.dest = *(uint32_t*)RTA_DATA(rta);
139+
break;
140+
case RTA_GATEWAY:
141+
entry.gateway = *(uint32_t*)RTA_DATA(rta);
142+
break;
143+
case RTA_PREFSRC:
144+
entry.src = *(uint32_t*)RTA_DATA(rta);
145+
break;
146+
case RTA_PRIORITY:
147+
entry.metric = *(uint32_t*)RTA_DATA(rta);
148+
break;
149+
case RTA_OIF:
150+
entry.ifindex = *(uint32_t*)RTA_DATA(rta);
151+
break;
152+
}
153+
}
154+
155+
if (entry.gateway == 0 || entry.dest != 0 || entry.prefix_length != 0)
156+
continue;
157+
158+
if (best_gw.gateway == 0 || entry.metric < best_gw.metric) {
159+
memcpy(&best_gw, &entry, sizeof(struct Route4Entry));
160+
}
161+
}
162+
163+
free(buffer);
164+
165+
if (best_gw.gateway != 0) {
166+
if (ifIndex) {
167+
*ifIndex = best_gw.ifindex;
168+
}
169+
if (iface) {
170+
if (if_indextoname(best_gw.ifindex, iface) == NULL) {
171+
iface[0] = '\0';
172+
}
173+
}
174+
if (preferredSourceAddr) {
175+
*preferredSourceAddr = best_gw.src;
176+
}
23177
return true;
24178
}
179+
25180
iface[0] = '\0';
26181
return false;
27182
}
@@ -43,9 +198,9 @@ static bool getDefaultRouteIPv6(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex)
43198
return false;
44199
}
45200

46-
bool ffNetifGetDefaultRouteImpl(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex)
201+
bool ffNetifGetDefaultRouteImpl(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex, uint32_t* preferredSourceAddr)
47202
{
48-
if (getDefaultRouteIPv4(iface, ifIndex))
203+
if (getDefaultRouteIPv4(iface, ifIndex, preferredSourceAddr))
49204
return true;
50205

51206
return getDefaultRouteIPv6(iface, ifIndex);

src/common/netif/netif_windows.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
#include <ws2tcpip.h> // AF_INET6, IN6_IS_ADDR_UNSPECIFIED
55
#include <iphlpapi.h>
66

7-
bool ffNetifGetDefaultRouteImpl(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex)
7+
bool ffNetifGetDefaultRouteImpl(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex, uint32_t* preferredSourceAddr)
88
{
99
PMIB_IPFORWARD_TABLE2 pIpForwardTable = NULL;
1010

src/detection/localip/localip_linux.c

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ const char* ffDetectLocalIps(const FFLocalIpOptions* options, FFlist* results)
136136
return "getifaddrs(&ifAddrStruct) failed";
137137

138138
const char* defaultRouteIfName = ffNetifGetDefaultRouteIfName();
139+
const uint32_t preferredSourceAddr = ffNetifGetDefaultRoutePreferredSourceAddr();
139140

140141
for (struct ifaddrs* ifa = ifAddrStruct; ifa; ifa = ifa->ifa_next)
141142
{
@@ -146,8 +147,8 @@ const char* ffDetectLocalIps(const FFLocalIpOptions* options, FFlist* results)
146147
continue;
147148
#endif
148149

149-
bool isDefaultRoute = ffStrEquals(defaultRouteIfName, ifa->ifa_name);
150-
if ((options->showType & FF_LOCALIP_TYPE_DEFAULT_ROUTE_ONLY_BIT) && !isDefaultRoute)
150+
bool isDefaultRouteIf = ffStrEquals(defaultRouteIfName, ifa->ifa_name);
151+
if ((options->showType & FF_LOCALIP_TYPE_DEFAULT_ROUTE_ONLY_BIT) && !isDefaultRouteIf)
151152
continue;
152153

153154
if ((ifa->ifa_flags & IFF_LOOPBACK) && !(options->showType & FF_LOCALIP_TYPE_LOOP_BIT))
@@ -164,6 +165,11 @@ const char* ffDetectLocalIps(const FFLocalIpOptions* options, FFlist* results)
164165
continue;
165166

166167
struct sockaddr_in* ipv4 = (struct sockaddr_in*) ifa->ifa_addr;
168+
169+
bool isDefaultRoute = isDefaultRouteIf && preferredSourceAddr != 0 && ipv4->sin_addr.s_addr == preferredSourceAddr;
170+
if ((options->showType & FF_LOCALIP_TYPE_DEFAULT_ROUTE_ONLY_BIT) && !isDefaultRoute)
171+
continue;
172+
167173
char addressBuffer[INET_ADDRSTRLEN + 16];
168174
inet_ntop(AF_INET, &ipv4->sin_addr, addressBuffer, INET_ADDRSTRLEN);
169175

@@ -203,7 +209,7 @@ const char* ffDetectLocalIps(const FFLocalIpOptions* options, FFlist* results)
203209
}
204210
}
205211

206-
addNewIp(results, ifa->ifa_name, addressBuffer, AF_INET6, isDefaultRoute, flags, !(options->showType & FF_LOCALIP_TYPE_ALL_IPS_BIT));
212+
addNewIp(results, ifa->ifa_name, addressBuffer, AF_INET6, isDefaultRouteIf, flags, !(options->showType & FF_LOCALIP_TYPE_ALL_IPS_BIT));
207213
}
208214
#if __FreeBSD__ || __OpenBSD__ || __APPLE__ || __NetBSD__ || __HAIKU__
209215
else if (ifa->ifa_addr->sa_family == AF_LINK)
@@ -227,7 +233,7 @@ const char* ffDetectLocalIps(const FFLocalIpOptions* options, FFlist* results)
227233
uint8_t* ptr = ((struct sockaddr_ll *)ifa->ifa_addr)->sll_addr;
228234
snprintf(addressBuffer, ARRAY_SIZE(addressBuffer), "%02x:%02x:%02x:%02x:%02x:%02x",
229235
ptr[0], ptr[1], ptr[2], ptr[3], ptr[4], ptr[5]);
230-
addNewIp(results, ifa->ifa_name, addressBuffer, -1, isDefaultRoute, flags, false);
236+
addNewIp(results, ifa->ifa_name, addressBuffer, -1, isDefaultRouteIf, flags, false);
231237
}
232238
#endif
233239
}

0 commit comments

Comments
 (0)