Conversation
This reverts commit ed2dd8f.
* add soar packages count * use || instead of concat for better compatibility with older SQLite versions * convert package flags to 64-bit
Regression of v2.40.0
* Add anduinos * fix logo. * Update anduinos.txt
No Administrator privileges needed
Completely untested.
* Logo (Builtin): Add 2 more Alpine logos * Remove unnecessary $1 in ASCII logo file * Add type field to Alpine2 logo configuration --------- Co-authored-by: naix <naix@noreply.codeberg.org> Co-authored-by: Carter Li <CarterLi@users.noreply.github.com>
As suggested by MSDN
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the v2.41.0 release by introducing new features and improvements across multiple components, including package detection, network interface data extraction, GPU and CPU detection enhancements, Windows-specific improvements, and updated CI workflows.
- Added "soar" package count detection for Linux.
- Improved file descriptor-based reading in netio and enhanced platform-specific implementations for CPU, GPU, and Bluetooth detection.
- Introduced new initialization functions and updated CI configurations for modern operating systems.
Reviewed Changes
Copilot reviewed 41 out of 43 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/detection/packages/packages_linux.c | Introduces soar package detection with a cumulative operator. |
| src/detection/packages/packages.h | Adds declaration for the newly introduced soar field. |
| src/detection/netio/netio_linux.c | Updates file reading to use file descriptors and relative paths. |
| src/detection/gpu/gpu_linux.c | Adjusts Intel GPU detection by adding an options parameter. |
| src/detection/cpu/{cpu_windows.c, cpu_linux.c, cpu_bsd.c, cpu_arm.h} | Implements various improvements to CPU detection, including thermal sensing and physical core detection. |
| src/detection/bluetooth/bluetooth_bsd.c | Adds platform-specific logic for Bluetooth device name generation. |
| src/common/processing_windows.c | Refines error handling and conditional code for Windows process I/O. |
| src/common/io/io_windows.c | Implements tilde path expansion on Windows. |
| src/common/init.{h,c} | Introduces new initialization functions. |
| README.md, CHANGELOG.md, .github/workflows/ci.yml | Updates documentation and CI/CD configurations, including support for additional platforms. |
Files not reviewed (2)
- CMakeLists.txt: Language not supported
- doc/json_schema.json: Language not supported
Comments suppressed due to low confidence (1)
src/common/processing_windows.c:152
- There is an inconsistency in the macro usage: the branch checking for aarch64 uses a different macro (arch64) in the error message construction. Verify and standardize the preprocessor macro to ensure consistent behavior across architectures.
return "GetOverlappedResult"
#if __arch64__
"Ex"
#endif
"(hChildPipeRead) failed";
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.