T2/SDE: upstreaming downstream's logo change#1695
Merged
CarterLi merged 2 commits intofastfetch-cli:devfrom Apr 17, 2025
Merged
T2/SDE: upstreaming downstream's logo change#1695CarterLi merged 2 commits intofastfetch-cli:devfrom
CarterLi merged 2 commits intofastfetch-cli:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/logo/builtin.c:4593
- Ensure that the alternative logo names align with the overall branding guidelines and are referenced correctly throughout the codebase.
.names = {"T2", "T2 SDE", "T2/Linux"},
src/logo/ascii/t2.txt:4
- Verify that the new ASCII art format, with its embedded color placeholders, renders correctly across all target terminal environments.
$1TTTTTTTTTTTTTTT$2 $3//$2 $1..::$2 $4:-:.$2
Member
|
Instead of removing the old one, it should be good to rename it to |
T2/SDE port of fastfetch applies two patches, improving the distribution's logo and adding alternative names. I see no point not having these upstream. Downstream's patches are found here: https://github.com/rxrbln/t2sde/tree/main/package/contrib/fastfetch The old logo has been renamed to "T2_small".
x-zvf
force-pushed
the
backport-t2sde-logo
branch
from
b7f4535 to
001de1c
Compare
Contributor
Author
Good idea, done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T2/SDE port of fastfetch applies two patches, improving the distribution's logo and adding alternative names. I see no point not having these upstream.
Downstream's patches are found here (SVN mirror):
https://github.com/rxrbln/t2sde/tree/main/package/contrib/fastfetch