Release: v2.43.0

[CarterLi]

No description provided.

[Copilot]

Pull Request Overview

This PR prepares the next release by introducing several enhancements (including amended media detection, improved GPU and CPU detection logic, and updated third‐party dependencies) and version updates across the codebase. Key changes include:

• Updates to media detection logic on Linux and macOS.
• Revised GPU detection including removal of outdated AMD shared memory detection and updated DRM handling.
• Adjustments to CPU detection on various platforms along with version bumps and updated metadata.

Reviewed Changes

Copilot reviewed 172 out of 172 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/detection/media/media_linux.c	Clears an additional status buffer to avoid duplicated playback status.
src/detection/media/media_apple.m	Renames media retrieval functions and adds osascript-based media detection for macOS 15.4 and above.
src/detection/gpu/gpu_linux.c	Adds support for Asahi DRM detection and refines AMD GPU VRAM type reporting via a new macro.
src/detection/gpu/gpu_asahi.h	Removes old Asahi DRM header in favor of a new, unified approach.
src/detection/gpu/gpu_amd.c	Removes deprecated shared memory detection while ensuring dedicated VRAM usage is non-negative.
src/detection/displayserver/linux/xcb.c	Improves error handling by checking the connection error status rather than NULL.
src/detection/disk/disk_linux.c	Uses explicit casting to avoid overflow in disk size calculations on 32-bit systems.
src/detection/cpu/*	Adjusts platform-specific CPU detection (Windows, SunOS, BSD) for more accurate data and simplified logic.
src/data/nowPlaying.scptd	Updates AppleScript for now-playing information retrieval.
debian/* and CMakeLists.txt	Updates version numbers and metadata for the upcoming release.

Comments suppressed due to low confidence (1)

src/detection/cpu/cpu_bsd.c:60

• [nitpick] The new loop for counting CPU packages is concise; please verify that this pattern reliably handles all expected XML/markup group formats in the system output.

for (char* p = buffer.chars; (p = strstr(p, "\n </group>\n")); ++p)

[Copilot]

Pull Request Overview

This PR prepares the v2.43.0 release with updates to media, GPU, and CPU detection along with several bug fixes and improvements.

• Updated media detection on macOS and Linux
• Revised GPU detection logic, including Asahi and AMD updates
• Enhanced CPU detection for Windows, SunOS, and BSD; version bumps and build system updates

Reviewed Changes

Copilot reviewed 175 out of 175 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/detection/media/media_linux.c	Cleared an additional string buffer for status to avoid residual data
src/detection/media/media_apple.m	Renamed media detection functions and integrated osascript-based detection for macOS 15.4
src/detection/gpu/gpu_linux.c	Updated DRM inclusion and detection logic with Asahi-specific adjustments
src/detection/gpu/gpu_asahi.h	Removed obsolete Asahi header
src/detection/gpu/gpu_amd.c	Removed shared memory detection and extra symbol loading for AMD GPU detection
src/detection/gpu/adl.h	Removed VRAM usage API declarations consistent with amd changes
src/detection/displayserver/linux/xcb.c	Added error checking for xcb connection using xcb_connection_has_error
src/detection/disk/disk_linux.c	Fixed multiplication to avoid integer overflow in disk capacity calculations
src/detection/cpu/cpu_windows.c	Replaced PDH functions with wide-character variants for improved compatibility
src/detection/cpu/cpu_sunos.c	Added a helper to count CPU IDs and updated detection logic
src/detection/cpu/cpu_bsd.c	Updated physical core and package count detection using sysctl output processing
src/data/nowPlaying.scptd	Added AppleScript for media information retrieval on macOS
src/data/help.json	Updated GPU hide option help text to include the "unknown" type
src/common/parsing.c	Added explicit type casts to ensure safe arithmetic with duration values
src/3rdparty/yyjson/repo.json	Updated yyjson version
doc/json_schema.json	Updated enum definition with the new GPU hide option
debian/files	Bumped the source build info version
debian/changelog	Added new changelog entries for v2.43.0 and updated previous version information
CMakeLists.txt	Updated project version to v2.43.0 and added nowPlaying.scptd loading for macOS
CHANGELOG.md	Documented new features and bugfixes along with versioning update

Comments suppressed due to low confidence (2)

CMakeLists.txt:349

• [nitpick] The removal of the regex substitution for logo text processing might affect the intended formatting. Confirm that this change is deliberate and that the logos render as expected without this replacement.

string(REGEX REPLACE "\\$\\{c([0-9]+)\\}" "\$\1" content "${content}")

src/detection/cpu/cpu_bsd.c:60

• [nitpick] The updated package counting logic uses substring matching which may be sensitive to output formatting changes. Consider verifying this approach against varied sysctl output formats to ensure its robustness.

for (char* p = buffer.chars; (p = strstr(p, "\n </group>\n")); ++p)