TerminalShell (Linux): better support for Ghostty#1803
Conversation
| getenv("GHOSTTY_RESOURCES_DIR") != NULL || | ||
| getenv("GHOSTTY_SHELL_INTEGRATION_NO_SUDO") != NULL || | ||
| getenv("GHOSTTY_BIN_DIR") != NULL | ||
| ) term = "Ghostty"; |
There was a problem hiding this comment.
Ghostty reports $TERM_PROGRAM, so additional env-var checks are not needed.
apocelipes
force-pushed
the
feat-ghostty
branch
2 times, most recently
from
da1096c to
535c877
Compare
|
Ubuntu: Arch Linux: |
apocelipes
force-pushed
the
feat-ghostty
branch
2 times, most recently
from
d6fd359 to
16373f4
Compare
apocelipes
changed the title
|
Rebased. Commit message has been updated. |
|
Hello. Please reply my comments first. |
I'm sorry, I didn't see it, could you quote-reply the comment and @ me? I only saw this and replied: |
|
|
@CarterLi So, where is your comment? Could you paste a screenshot like what I did? |
CarterLi
left a comment
CarterLi
left a comment
There was a problem hiding this comment.
Please review these comments
| if(version->length > 0) return true; | ||
| } | ||
|
|
||
| if(!getExeVersionRaw(exe, version)) return false; |
There was a problem hiding this comment.
I actually dont think this is needed. As $TERMINAL_PROGRAM_VERSION exists.
We rely on it for some other terminals too, such as Wezterm, iTerm and warp.
Note we always add another detection method after ffBinaryExtractStrings usage, as ffBinaryExtractStrings relies on the internal implementation of terminals which is not very reliable. While $TERMINAL_PROGRAM_VERSION is considerred a public API; if the variable is not there it is a terminal bug.
| if (env) | ||
| { | ||
| ffStrbufAppendS(version, env); | ||
| // 1.1.3-arch1 |
There was a problem hiding this comment.
FYI fedora version also includes .fc42. Lets keep as it was.
There was a problem hiding this comment.
For nightly version, ghostty --version includes the branch name and commit hash.
There was a problem hiding this comment.
The kernel version contains archlinux specific suffix -arch1-1. I don't think it's problematic. Do you?
|
Can you see it now? |
Thanks, I can see it now. Maybe it's Github's bug that it didn't display to me. |
|
The version suffix doesn't indicate a change in the program code, sometimes the suffix changes simply by packager recompiling it. Many other programs don't have the suffix in their versions output, such as bash (usually this is a side effect of the formatting), so I'm considering whether or not to remove ghostty's version suffix just the same. But since Fedora also has a version suffix, I think it's okay to keep it. I'll close this PR. Thanks for your review. |
2 participants
Changes:
Ghostty does not support Windows (still WIP at an early stage), so only *nix parts modified.