Conversation
…n different platforms
Contributor
There was a problem hiding this comment.
Pull Request Overview
This is a release PR for version 2.48.1 that introduces conditional module support, improves package manager handling, and fixes cross-platform compatibility issues. The changes include:
- Adding conditional module execution based on system and architecture
- Adding a
combinedoption for package managers to merge related counts - Improving process spawning reliability on Windows and fixing compatibility for Android/OpenBSD
- Adding Openbox WM version detection support
Reviewed Changes
Copilot reviewed 89 out of 89 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Multiple module files | Add support for "condition" key in JSON parsing to enable conditional modules |
| src/modules/packages/* | Add combined package manager option and related logic |
| src/common/jsonconfig.c | Implement conditional module execution logic based on system/arch matching |
| src/common/processing_*.c | Improve process spawning and fix platform compatibility issues |
| src/common/io/* | Add ffGetNullFD function for consistent null file descriptor handling |
| src/detection/wm/wm_linux.c | Add Openbox version detection and refactor common version extraction |
| Version/config files | Update version numbers, changelog, and configuration schemas |
Comments suppressed due to low confidence (1)
src/detection/wm/wm_linux.c:179
- [nitpick] The function name 'extractCommonWmVersion' could be more descriptive. Consider 'extractVersionFromBinary' or 'extractVersionPattern' to better indicate its purpose of extracting version strings matching x.y.z pattern.
static bool extractCommonWmVersion(const char* line, FF_MAYBE_UNUSED uint32_t len, void *userdata)
Comment on lines
+103
to
+104
| FF_PRINT_PACKAGE_NAME(brew, "brew") | ||
| FF_PRINT_PACKAGE_NAME(brewCask, "brew-cask") |
There was a problem hiding this comment.
The macro call is missing a closing brace according to the new macro definition pattern. The FF_PRINT_PACKAGE_NAME macro now uses curly braces but this call doesn't follow the pattern.
Suggested change
| FF_PRINT_PACKAGE_NAME(brew, "brew") | |
| FF_PRINT_PACKAGE_NAME(brewCask, "brew-cask") | |
| FF_PRINT_PACKAGE_NAME({brew, "brew"}) | |
| FF_PRINT_PACKAGE_NAME({brewCask, "brew-cask"}) |
| return "CreateFileW(L\"\\\\.\\pipe\\FASTFETCH-$(PID)\") failed"; | ||
|
|
||
| PROCESS_INFORMATION piProcInfo = {0}; | ||
| PROCESS_INFORMATION piProcInfo = {}; |
There was a problem hiding this comment.
[nitpick] Using empty brace initialization '{}' instead of '{0}' is a C++ style. In C, '{0}' is more conventional and explicitly shows zero-initialization intent.
Suggested change
| PROCESS_INFORMATION piProcInfo = {}; | |
| PROCESS_INFORMATION piProcInfo = {0}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.