fix: reduce the numbers of onReady hooks (#932)

Author: climba03003

lib/util/add-hook.js

@@ -5,6 +5,7 @@ const cloner = require('rfdc')({ proto: true, circles: false })
 
 function addHook (fastify, pluginOptions) {
   const routes = []
+  const instances = []
   const sharedSchemasMap = new Map()
   let hookRun = false
 
@@ -37,27 +38,27 @@ function addHook (fastify, pluginOptions) {
   })
 
   fastify.addHook('onRegister', async (instance) => {
-    // we need to wait the ready event to get all the .getSchemas()
-    // otherwise it will be empty
-    // TODO: better handle for schemaId
-    // when schemaId is the same in difference instance
-    // the latter will lost
-    instance.addHook('onReady', (done) => {
-      const allSchemas = instance.getSchemas()
-      for (const schemaId of Object.keys(allSchemas)) {
-        sharedSchemasMap.set(schemaId, allSchemas[schemaId])
-      }
-      done()
-    })
+    instances.push(instance)
   })
 
   fastify.addHook('onReady', (done) => {
     hookRun = true
+    for (const instance of instances) {
+      // TODO: better handle for schemaId
+      // when schemaId is the same in difference instance
+      // the latter will lost
+      const allSchemas = instance.getSchemas()
+      for (const schemaId of Object.keys(allSchemas)) {
+        sharedSchemasMap.set(schemaId, allSchemas[schemaId])
+      }
+    }
     const allSchemas = fastify.getSchemas()
     for (const schemaId of Object.keys(allSchemas)) {
       // it is the top-level, we do not expect to have duplicate id
       sharedSchemasMap.set(schemaId, allSchemas[schemaId])
     }
+    // clear the instances array to avoid memory leak
+    instances.length = 0
     done()
   })