Action merges PRs with failed checks

[profoundvision]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the bug has not already been reported

Fastify version

?

Plugin version

3

Node.js version

?

Operating system

Linux

Operating system version (i.e. 20.04, 11.3, 10)

?

Description

When using this action it automatically merges PRs where the checks have failed.
This doesn't seem like correct behaviour. I was considering using the auto approve + Github native auto merge but I think you need a premium account for this,
Also the 'needs' field seems to refer to jobs in the same action instead of other checks.

This is my config:

name: Dependabot auto-merge
on:
  push:
    branches:
      - main
  pull_request:

jobs:
  automerge:
    runs-on: ubuntu-latest

    permissions:
      pull-requests: write
      contents: write

    steps:
      - uses: fastify/github-action-merge-dependabot@v3

Link to code that reproduces the bug

?

Expected Behavior

I expect this action to only merge PRs where all checks passed.

[SociableSteve]

Thanks for the report. Unfortunately the use of needs to add dependencies on external jobs is a limitation of the actions system in Github where jobs cannot be dependencies across different workflows - it's been discussed for years with no resolution.

Workflows are seen as independent sets of one or more jobs and so it's normal to contain the automerge job within the same workflow as the job with your jobs.

There are likely actions to help with this which exist which you could add here, such as https://github.com/marketplace/actions/pr-status, https://github.com/marketplace/actions/add-pr-checks, or others, however this is beyond the scope of this specific action.