Skip to content

Commit 0540c8a

Browse files
authored
chore: exclude Node 14 and 16 on macos (#127) (#128)
* chore: exclude Node 14 and 16 on macos Related to fastify/.github#37. This is just a proposal, probably not comprehensive of all the places where a similar change may have to occur, simply to capture that this is possible (and I didn't know until now) to exclude combinations, as documented in https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations * remove os matrix from package --------- Signed-off-by: Simone Busoli <simone.busoli@gmail.com>
1 parent 758b570 commit 0540c8a

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

.github/workflows/plugins-ci-package-manager.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,18 @@ on:
66
jobs:
77
pnpm:
88
name: pnpm
9-
runs-on: ${{ matrix.os }}
9+
runs-on: ubuntu-latest
1010
permissions:
1111
contents: read
1212
strategy:
1313
matrix:
1414
node-version: [16, 18, 20, 21]
15-
os: [ubuntu-latest]
1615
pnpm-version: [8]
1716
# pnpm@8 does not support Node.js 14 so include it separately
1817
include:
1918
- node-version: 14
2019
os: ubuntu-latest
2120
pnpm-version: 7
22-
2321
steps:
2422
- name: Check out repo
2523
uses: actions/checkout@v4
@@ -44,13 +42,12 @@ jobs:
4442

4543
yarn:
4644
name: Yarn
47-
runs-on: ${{ matrix.os }}
45+
runs-on: ubuntu-latest
4846
permissions:
4947
contents: read
5048
strategy:
5149
matrix:
5250
node-version: [14, 16, 18, 20]
53-
os: [ubuntu-latest]
5451
steps:
5552
- name: Check out repo
5653
uses: actions/checkout@v4

.github/workflows/plugins-ci.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,10 @@ jobs:
108108
exclude:
109109
- os: windows-latest
110110
node-version: 14
111+
- os: macos-latest
112+
node-version: 14
113+
- os: macos-latest
114+
node-version: 16
111115
steps:
112116
- name: Check out repo
113117
uses: actions/checkout@v4

0 commit comments

Comments
 (0)