Skip to content

Commit 5242324

Browse files
authored
perf: allow quality-check and test jobs to run in parallel (#184)
1 parent 02b6732 commit 5242324

7 files changed

Lines changed: 7 additions & 17 deletions

File tree

.github/workflows/plugins-ci-elasticsearch.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ jobs:
4747

4848
test:
4949
name: Node.js ${{ matrix.node-version }}
50-
needs: quality-check
5150
runs-on: ubuntu-latest
5251
strategy:
5352
matrix:
@@ -87,7 +86,7 @@ jobs:
8786
if: >
8887
github.event_name == 'pull_request' &&
8988
github.event.pull_request.user.login == 'dependabot[bot]'
90-
needs: test
89+
needs: [quality-check, test]
9190
permissions:
9291
pull-requests: write
9392
contents: write

.github/workflows/plugins-ci-kafka.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ jobs:
4242

4343
test:
4444
name: Node.js ${{ matrix.node-version }}
45-
needs: quality-check
4645
runs-on: ubuntu-latest
4746
strategy:
4847
matrix:
@@ -91,7 +90,7 @@ jobs:
9190
if: >
9291
github.event_name == 'pull_request' &&
9392
github.event.pull_request.user.login == 'dependabot[bot]'
94-
needs: test
93+
needs: [quality-check, test]
9594
permissions:
9695
pull-requests: write
9796
contents: write

.github/workflows/plugins-ci-mongo.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ jobs:
4242

4343
test:
4444
name: Node.js ${{ matrix.node-version }} - ${{ matrix.db }}
45-
needs: quality-check
4645
runs-on: ubuntu-latest
4746
permissions:
4847
contents: read
@@ -79,7 +78,7 @@ jobs:
7978
if: >
8079
github.event_name == 'pull_request' &&
8180
github.event.pull_request.user.login == 'dependabot[bot]'
82-
needs: test
81+
needs: [quality-check, test]
8382
permissions:
8483
pull-requests: write
8584
contents: write

.github/workflows/plugins-ci-mysql.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ jobs:
4242

4343
test:
4444
name: Node.js ${{ matrix.node-version }} - ${{ matrix.db }}
45-
needs: quality-check
4645
runs-on: ubuntu-latest
4746
permissions:
4847
contents: read
@@ -85,7 +84,7 @@ jobs:
8584
if: >
8685
github.event_name == 'pull_request' &&
8786
github.event.pull_request.user.login == 'dependabot[bot]'
88-
needs: test
87+
needs: [quality-check, test]
8988
permissions:
9089
pull-requests: write
9190
contents: write

.github/workflows/plugins-ci-postgres.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ jobs:
4242

4343
test:
4444
name: Node.js ${{ matrix.node-version }} - ${{ matrix.db }}
45-
needs: quality-check
4645
runs-on: ubuntu-latest
4746
permissions:
4847
contents: read
@@ -100,7 +99,7 @@ jobs:
10099
if: >
101100
github.event_name == 'pull_request' &&
102101
github.event.pull_request.user.login == 'dependabot[bot]'
103-
needs: test
102+
needs: [quality-check, test]
104103
permissions:
105104
pull-requests: write
106105
contents: write

.github/workflows/plugins-ci-redis.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ jobs:
4242

4343
test:
4444
name: Node.js ${{ matrix.node-version }} - ${{ matrix.db }}
45-
needs: quality-check
4645
runs-on: ubuntu-latest
4746
strategy:
4847
matrix:
@@ -78,7 +77,7 @@ jobs:
7877
if: >
7978
github.event_name == 'pull_request' &&
8079
github.event.pull_request.user.login == 'dependabot[bot]'
81-
needs: test
80+
needs: [quality-check, test]
8281
permissions:
8382
pull-requests: write
8483
contents: write

.github/workflows/plugins-ci.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ jobs:
4747

4848
test:
4949
name: Test
50-
needs: quality-check
5150
runs-on: ${{ matrix.os }}
5251
permissions:
5352
contents: read
@@ -84,7 +83,6 @@ jobs:
8483

8584
fastify-dependency-integration:
8685
name: Test Fastify Integration
87-
needs: quality-check
8886
runs-on: ubuntu-latest
8987
if: >
9088
!failure() &&
@@ -125,9 +123,7 @@ jobs:
125123
(needs.fastify-dependency-integration.result == 'success' || needs.fastify-dependency-integration.result == 'skipped') &&
126124
github.event_name == 'pull_request' &&
127125
github.event.pull_request.user.login == 'dependabot[bot]'
128-
needs:
129-
- test
130-
- fastify-dependency-integration
126+
needs: [fastify-dependency-integration, quality-check, test]
131127
permissions:
132128
pull-requests: write
133129
contents: write

0 commit comments

Comments
 (0)