code smell fixes

Author: lucasstarsz

src/main/java/tech/fastj/graphics/textures/Textures.java

@@ -6,6 +6,11 @@
 import java.nio.file.Path;
 
 public class Textures {
+
+    private Textures() {
+        throw new IllegalStateException();
+    }
+
     public static TexturePaint create(Path texturePath, Rectangle2D textureLocation) {
         return TextureBuilder.builder(texturePath, textureLocation).build();
     }

src/main/java/tech/fastj/input/mouse/Mouse.java

@@ -185,7 +185,7 @@ public static void init() {
      */
     public static boolean interactsWith(Drawable button, MouseAction recentMouseAction) {
         PathIterator buttonPathIterator = button.getCollisionPath().getPathIterator(null);
-        return Path2D.Float.intersects(buttonPathIterator, mouseLocation.x, mouseLocation.y, 1, 1) && recentMouseAction.recentAction;
+        return Path2D.intersects(buttonPathIterator, mouseLocation.x, mouseLocation.y, 1, 1) && recentMouseAction.recentAction;
     }
 
     /**

src/main/java/tech/fastj/math/Point.java

@@ -13,7 +13,14 @@
  */
 public class Point {
 
-    /** {@code Point} representing the origin as an {@code int}: {@code (0, 0)}. */
+    /**
+     * {@code Point} representing the origin as an {@code int}: {@code (0, 0)}.
+     *
+     * @deprecated As an object, users are likely to accidentally modify this value. Furthermore, Java will likely not
+     * receive <a href="https://openjdk.java.net/jeps/401" target="_blank">primitive objects</a> any time soon, so this
+     * value will be removed very soon. Use {@link Point#origin()} instead.
+     */
+    @Deprecated
     public static final Point Origin = new Point();
 
     /** The x value of the {@link Point}. */
@@ -81,54 +88,61 @@ public Point(int xVal, int yVal) {
     }
 
     /**
-     * {@code Point} representing a 2D graph's origin as a pair of {@code integer}s: {@code (0, 0)}.
+     * {@code Point} representing a 2D graph's origin as a pair of {@code integer}s: {@code (0, 0)}. Each returned
+     * instance is a newly created object.
      *
-     * @return The {@code origin} instance.
+     * @return An {@code origin} instance.
+     * @since 1.6.0
      */
     public static Point origin() {
         return new Point();
     }
 
     /**
-     * {@code Point} representing a unit vector in a 2D graph as a pair of {@code integer}s: {@code (0, 0)}.
+     * {@code Point} representing a unit vector in a 2D graph as a pair of {@code integer}s: {@code (0, 0)}. Each
+     * returned instance is a newly created object.
      *
-     * @return The {@code unit} vector instance.
+     * @return A {@code unit} vector instance.
      */
     public static Point unit() {
         return new Point(1);
     }
 
     /**
-     * {@code Point} representing an up vector in a 2D graph as a pair of {@code integer}s: {@code (0, -1)}.
+     * {@code Point} representing an up vector in a 2D graph as a pair of {@code integer}s: {@code (0, -1)}. Each
+     * returned instance is a newly created object.
      *
-     * @return The {@code up} vector instance.
+     * @return An {@code up} vector instance.
      */
     public static Point up() {
         return new Point(0, -1);
     }
 
     /**
-     * {@code Point} representing a down vector in a 2D graph as a pair of {@code integer}s: {@code (0, 1)}.
+     * {@code Point} representing a down vector in a 2D graph as a pair of {@code integer}s: {@code (0, 1)}. Each
+     * returned instance is a newly created object.
      *
-     * @return The {@code down} vector instance.
+     * @return A {@code down} vector instance.
      */
     public static Point down() {
         return new Point(0, 1);
     }
 
     /**
-     * {@code Point} representing a left vector in a 2D graph as a pair of {@code integer}s: {@code (-1, 0)}.
+     * {@code Point} representing a left vector in a 2D graph as a pair of {@code integer}s: {@code (-1, 0)}. Each
+     * returned instance is a newly created object.
      *
-     * @return The {@code left} vector instance.
+     * @return A {@code left} vector instance.
      */
     public static Point left() {
         return new Point(-1, 0);
     }
 
     /**
-     * {@code Point} representing a right vector in a 2D graph as a pair of {@code integer}s: {@code (1, 0)}.
+     * {@code Point} representing a right vector in a 2D graph as a pair of {@code integer}s: {@code (1, 0)}. Each
+     * returned instance is a newly created object.
      *
-     * @return The {@code right} vector instance.
+     * @return A {@code right} vector instance.
      */
     public static Point right() {
         return new Point(1, 0);
@@ -317,8 +331,8 @@ public static int cross(Point p, Point p1) {
      * @return The calculated distance.
      */
     public static float distance(Point p, Point p1) {
-        float differenceX = p1.x - p.x;
-        float differenceY = p1.y - p.y;
+        float differenceX = (float) p1.x - p.x;
+        float differenceY = (float) p1.y - p.y;
         return (float) Math.sqrt(differenceX * differenceX + differenceY * differenceY);
     }
 

src/main/java/tech/fastj/math/Pointf.java

@@ -12,7 +12,14 @@
  */
 public class Pointf {
 
-    /** {@code Pointf} representing the origin as a {@code float}: {@code (0f, 0f)}. */
+    /**
+     * {@code Pointf} representing the origin as a {@code float}: {@code (0f, 0f)}.
+     *
+     * @deprecated As an object, users are likely to accidentally modify this value. Furthermore, Java will likely not
+     * receive <a href="https://openjdk.java.net/jeps/401" target="_blank">primitive objects</a> any time soon, so this
+     * value will be removed very soon. Use {@link Pointf#origin()} instead.
+     */
+    @Deprecated
     public static final Pointf Origin = new Pointf();
 
     /** The x value of the {@link Pointf}. */
@@ -68,54 +75,61 @@ public Pointf(float xVal, float yVal) {
     }
 
     /**
-     * {@code Pointf} representing a 2D graph's origin as a pair of {@code float}s: {@code (0f, 0f)}.
+     * A new {@code Pointf} representing a 2D graph's origin as a pair of {@code float}s: {@code (0f, 0f)}. Each
+     * returned instance is a newly created object.
      *
-     * @return The {@code origin} instance.
+     * @return An {@code origin} instance.
+     * @since 1.6.0
      */
     public static Pointf origin() {
         return new Pointf();
     }
 
     /**
-     * {@code Pointf} representing a unit vector in a 2D graph as a pair of {@code float}s: {@code (0f, 0f)}.
+     * {@code Pointf} representing a unit vector in a 2D graph as a pair of {@code float}s: {@code (0f, 0f)}. Each
+     * returned instance is a newly created object.
      *
-     * @return The {@code unit} vector instance.
+     * @return A {@code unit} vector instance.
      */
     public static Pointf unit() {
         return new Pointf(1f);
     }
 
     /**
-     * {@code Pointf} representing an up vector in a 2D graph as a pair of {@code float}s: {@code (0f, -1f)}.
+     * {@code Pointf} representing an up vector in a 2D graph as a pair of {@code float}s: {@code (0f, -1f)}. Each
+     * returned instance is a newly created object.
      *
-     * @return The {@code up} vector instance.
+     * @return An {@code up} vector instance.
      */
     public static Pointf up() {
         return new Pointf(0f, -1f);
     }
 
     /**
-     * {@code Pointf} representing a down vector in a 2D graph as a pair of {@code float}s: {@code (0f, 1f)}.
+     * {@code Pointf} representing a down vector in a 2D graph as a pair of {@code float}s: {@code (0f, 1f)}. Each
+     * returned instance is a newly created object.
      *
-     * @return The {@code down} vector instance.
+     * @return A {@code down} vector instance.
      */
     public static Pointf down() {
         return new Pointf(0f, 1f);
     }
 
     /**
-     * {@code Pointf} representing a left vector in a 2D graph as a pair of {@code float}s: {@code (-1f, 0f)}.
+     * {@code Pointf} representing a left vector in a 2D graph as a pair of {@code float}s: {@code (-1f, 0f)}. Each
+     * returned instance is a newly created object.
      *
-     * @return The {@code left} vector instance.
+     * @return A {@code left} vector instance.
      */
     public static Pointf left() {
         return new Pointf(-1f, 0f);
     }
 
     /**
-     * {@code Pointf} representing a right vector in a 2D graph as a pair of {@code float}s: {@code (1f, 0f)}.
+     * {@code Pointf} representing a right vector in a 2D graph as a pair of {@code float}s: {@code (1f, 0f)}. Each
+     * returned instance is a newly created object.
      *
-     * @return The {@code right} vector instance.
+     * @return A {@code right} vector instance.
      */
     public static Pointf right() {
         return new Pointf(1f, 0f);

src/main/java/tech/fastj/resources/ResourceManager.java

@@ -15,7 +15,7 @@ public abstract class ResourceManager<T extends Resource<V>, V> {
     protected final Map<Path, UUID> pathToUUIDMap;
     protected final Map<String, Path> idToPathMap;
 
-    public ResourceManager() {
+    protected ResourceManager() {
         resourceStorage = new ConcurrentHashMap<>();
         pathToUUIDMap = new ConcurrentHashMap<>();
         idToPathMap = new ConcurrentHashMap<>();

src/main/java/tech/fastj/resources/files/FileUtil.java

@@ -15,6 +15,10 @@
  */
 public class FileUtil {
 
+    private FileUtil() {
+        throw new IllegalStateException();
+    }
+
     /**
      * Gets the file extension of the specified path.
      * <p>

src/main/java/tech/fastj/resources/images/ImageUtil.java

@@ -20,6 +20,10 @@
 
 public class ImageUtil {
 
+    private ImageUtil() {
+        throw new IllegalStateException();
+    }
+
     public static VolatileImage createVolatileImage(int width, int height) {
         try {
             return GraphicsEnvironment.getLocalGraphicsEnvironment().getDefaultScreenDevice().getDefaultConfiguration().createCompatibleVolatileImage(