Skip to content

Commit 10dbeae

Browse files
Fix updating dynamic optimizer flows (#1481)
* fix DynamicFlow optimizer updates * Add DynamicFlow update regression test * [pre-commit.ci] auto fixes from pre-commit hooks --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent 68adb54 commit 10dbeae

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

hls4ml/model/flow/flow.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,10 @@ def optimizers(self):
6262
return optimizers
6363

6464
def _add_optimizer(self, opt_name):
65-
self._added_optimizers.put(opt_name)
65+
self._added_optimizers.add(opt_name)
6666

6767
def _remove_optimizer(self, opt_name):
68-
self._removed_optimizers.put(opt_name)
68+
self._removed_optimizers.add(opt_name)
6969

7070

7171
flow_map = {}

test/pytest/test_flows.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,3 +119,9 @@ def test_flows(tester):
119119
expected = tester.expected_pass_order
120120
observed = tester.observed_pass_order
121121
assert success, f'Tester {i} fails: expected ({expected}), observed ({observed})'
122+
123+
124+
def test_update_dynamic_flow():
125+
dynamic_flow = hls4ml.model.flow.register_flow('TestDynamicFlowUpdate', lambda: ['A', 'B'])
126+
hls4ml.model.flow.update_flow(dynamic_flow, add_optimizers=['C'], remove_optimizers=['A'])
127+
assert set(hls4ml.model.flow.get_flow(dynamic_flow).optimizers) == {'B', 'C'}

0 commit comments

Comments
 (0)