Skip to content

Change default part to agilex 7, turn of hyper-optimized handshaking, pass clock period#1304

Merged
calad0i merged 2 commits into
mainfrom
update_oneAPI_options
Jun 3, 2025
Merged

Change default part to agilex 7, turn of hyper-optimized handshaking, pass clock period#1304
calad0i merged 2 commits into
mainfrom
update_oneAPI_options

Conversation

@jmitrevs

Copy link
Copy Markdown
Contributor

Description

This fixes a bug in oneAPI that the passed clock period was ignored. Additionally, it adds an option to turn off or on the hyper-optimized handshaking (now default off, since usually it hurts, unless you really want high clocks), and it changes the default part to agilex 7 for oneAPI, updating the technology.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • Documentation update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • A new research paper code implementation
  • Other: change defaults

Tests

This should not break any pytests. The change should only matter for synthesis.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

# Use cmake -DUSER_FPGA_FLAGS=<flags> to set extra flags for FPGA backend
# compilation.
set(USER_FPGA_FLAGS -Wno-unused-label ${USER_FPGA_FLAGS})
set(USER_FPGA_FLAGS -Wno-unused-label;${USER_FPGA_FLAGS})

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I think it works this way, as a list, too. I am basing it on a model I am following--I am not really an expert on this. But this does seem to work. The stuff that is added about the clock speed and hyper-optimized or not is also done in this way.

@JanFSchulte JanFSchulte added the please test Trigger testing by creating local PR branch label Jun 3, 2025

@calad0i calad0i left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String/list change clarified, everything looks good. Merging.

@calad0i calad0i merged commit 03953ad into main Jun 3, 2025
5 of 7 checks passed
@calad0i calad0i deleted the update_oneAPI_options branch June 3, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please test Trigger testing by creating local PR branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants