Change default part to agilex 7, turn of hyper-optimized handshaking, pass clock period#1304
Merged
Conversation
calad0i
reviewed
Jun 1, 2025
| # Use cmake -DUSER_FPGA_FLAGS=<flags> to set extra flags for FPGA backend | ||
| # compilation. | ||
| set(USER_FPGA_FLAGS -Wno-unused-label ${USER_FPGA_FLAGS}) | ||
| set(USER_FPGA_FLAGS -Wno-unused-label;${USER_FPGA_FLAGS}) |
Contributor
Author
There was a problem hiding this comment.
Yes. I think it works this way, as a list, too. I am basing it on a model I am following--I am not really an expert on this. But this does seem to work. The stuff that is added about the clock speed and hyper-optimized or not is also done in this way.
calad0i
approved these changes
Jun 3, 2025
calad0i
left a comment
Contributor
There was a problem hiding this comment.
String/list change clarified, everything looks good. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug in oneAPI that the passed clock period was ignored. Additionally, it adds an option to turn off or on the hyper-optimized handshaking (now default off, since usually it hurts, unless you really want high clocks), and it changes the default part to agilex 7 for oneAPI, updating the technology.
Type of change
Tests
This should not break any pytests. The change should only matter for synthesis.
Checklist
pre-commiton the files I edited or added.