remove passing of size to stream clone and repack#1306
Closed
jmitrevs wants to merge 7 commits into
Closed
Conversation
Contributor
|
The latest changes improved things and seem to have actually fixed the stuck stream cloning test. But there are 2 remaining stuck tests, one in the ``test_pytorch_api |
Contributor
Author
|
The |
1 task
7 tasks
Contributor
Author
|
It turns out we do need to pass the size after all. The fixes discovered when working on this PR are now in #1354. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes the unused feature of clone stream and repack for oneAPI. Generally with oneAPI we don't support reading in multiple inputs as one.
While looking at the changes I found the bug: stream6 was written twice, with the data of stream 6 and stream7, while no data was sent to stream7. That fix has been incorporated here. It is easy to incorporate that fix in the master branch directly, but I think these other changes are worth having.
Type of change
Tests
The bug fix should make test_multi_fix work for oneAPI, and other pytests should not break because of the other changes.
Checklist
pre-commiton the files I edited or added.