Better handle types and overflows in softmax (especially lagacy and stable)#1476
Open
jmitrevs wants to merge 3 commits into
Open
Better handle types and overflows in softmax (especially lagacy and stable)#1476jmitrevs wants to merge 3 commits into
jmitrevs wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The legacy softmax was prone to overflow, so this PR made it use an accumulator type. Also, for stable, the default types are better chosen. There are some changes in latency, as well, to avoid overflow, but my feeling is that latency can often behave badly, so this doesn't fix that.
Type of change
Tests
The standard softmax tests should still pass. One could consider adding specific overflow tests, like we have in the current version of the brevitas tutorial.
Checklist
pre-commiton the files I edited or added.