Improve test_conv1d layer checks for io_stream + same padding#1479
Open
frabazz wants to merge 2 commits into
Open
Improve test_conv1d layer checks for io_stream + same padding#1479frabazz wants to merge 2 commits into
frabazz wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously,
test_conv1dskipped all layer-name and layer-property assertions whenever the backend was Vivado/Vitis withio_type='io_stream'andpadding='same'. In that configuration Vivado/Vitis inserts an extra padding layer after the input, which shifts every subsequent layer index by one.Instead of skipping the checks entirely, this PR introduces an index offset
off(1 in that specific case, 0 otherwise) so that all layers except the inserted padding layer are still validated. The padding layer itself is not checked because it lacks attributes such asname.As a result, layer-name and property checks now also run in the
io_stream+sameconfiguration, restoring coverage that was previously dropped.Type of change
Note: Please delete options that are not relevant.
Tests
The updated
test_conv1dpasses correctly in all configurations, including Vivado/Vitis withio_type='io_stream'andpadding='same'.Checklist
pre-commiton the files I edited or added.