fix(desktop): simplify STT model settings#5266
Merged
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
1a3c6e7 to
ffa59d3
Compare
Move the language warning into a full-width top banner, hide legacy Cactus model choices unless selected, compact selected and downloaded model rows, and show local model actions only on hover.
ffa59d3 to
89083d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the language warning into a full-width top banner, hide legacy Cactus model choices unless selected, compact selected and downloaded model rows, and show local model actions only on hover.
Note
Medium Risk
Primarily UI/UX refactoring, but it changes model-listing/query behavior (e.g., hiding deprecated Cactus models unless selected) and selection rendering, which could affect what models users can choose or see.
Overview
Moves the spoken-language compatibility warning out of the selector and into a full-width
TranscriptionLanguageWarningBannerrendered at the top of the STT settings page.Simplifies the model dropdown UX: the selected model now renders with the same icon/label treatment as list rows, deprecated models are visually de-emphasized, size is only shown for not-yet-downloaded models, and the cloud action button text is standardized to "Upgrade to use".
Changes local model listing/actions: deprecated Cactus models are hidden unless they’re the currently selected model (and only those are queried for download state), and local model row actions (show folder/delete) are now shown via a hover/focus overlay instead of tooltips.
Reviewed by Cursor Bugbot for commit 89083d7. Bugbot is set up for automated code reviews on this repo. Configure here.