fix(soniqo): bundle MLX metallib#5274
Merged
Merged
Conversation
Compile the MLX Metal shader library during the Soniqo Swift bridge build and copy it beside dev and bundled macOS binaries.
✅ Deploy Preview for old-char canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compile the MLX Metal shader library during the Soniqo Swift bridge build and copy it beside dev and bundled macOS binaries.
Note
Medium Risk
Touches the macOS build pipeline by adding custom
xcrunMetal compilation and file-copy steps, which can break CI/local builds or produce mismatched artifacts if paths/toolchain assumptions change.Overview
Ensures the MLX Metal shader library (
mlx.metallib) is produced during the macOS Apple Silicontranscribe-soniqobuild by adding a build-script step that collects MLX Swift Metal sources, compiles/links them viaxcrun metal/metallib, and only rebuilds when inputs change.Copies the generated
mlx.metallibnext to the built binaries and intoapps/desktop/src-tauri/resources, and updates both Tauri bundle configs to include it atMacOS/mlx.metallib(with the resource ignored in git).Reviewed by Cursor Bugbot for commit 8fe3a2c. Bugbot is set up for automated code reviews on this repo. Configure here.