fix(desktop): persist transcript-only batch output#5276
Merged
Conversation
Synthesize word timings for transcript-only batch responses and surface empty batch output as a no-speech error.
✅ Deploy Preview for old-char canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synthesize word timings for transcript-only batch responses and surface empty batch output as a no-speech error.
Note
Medium Risk
Moderate risk: changes core batch-transcription result handling and introduces synthesized timing data plus a new failure path when no words are produced.
Overview
Batch transcription now handles transcript-only outputs. When batch/streamed responses contain a
transcriptbut nowords, the listener synthesizesWordEntrytimings (using segment start/duration or overall metadata duration) so results can still be persisted.Empty batch output is now treated as an error.
handleBatchResponsereturns a boolean andrunBatchSessionrejects/marks the session failed withEMPTY_BATCH_TRANSCRIPT_ERRORwhen no words are produced; tests were added/updated to cover transcript-only persistence and the new no-speech failure behavior.Reviewed by Cursor Bugbot for commit bab1216. Bugbot is set up for automated code reviews on this repo. Configure here.