fix(desktop): package MLX metallib as resource#5289
Merged
Conversation
Move the bundled MLX Metal library under the SwiftPM Cmlx resource bundle path so macOS signing no longer treats it as nested executable code.
✅ Deploy Preview for old-char canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the bundled MLX Metal library under the SwiftPM Cmlx resource bundle path so macOS signing no longer treats it as nested executable code.
Note
Low Risk
Low risk: only adjusts macOS bundling paths for a single resource in Tauri config; main risk is a packaging/regression if the new metallib path is wrong and the app can’t find the Metal library at runtime.
Overview
Updates the macOS bundle
filesmapping intauri.conf.jsonandtauri.conf.staging.jsonto ship the MLX Metal library fromResources/mlx-swift_Cmlx.bundle/default.metallibinstead ofMacOS/mlx.metallib.This changes where
resources/mlx.metallibis placed in the packaged app to avoid macOS treating it as nested executable code during signing/notarization.Reviewed by Cursor Bugbot for commit caa980b. Bugbot is set up for automated code reviews on this repo. Configure here.