fix: remove stale announcement height constant#5069
Closed
ComputelessComputer wants to merge 1 commit intomainfrom
Closed
fix: remove stale announcement height constant#5069ComputelessComputer wants to merge 1 commit intomainfrom
ComputelessComputer wants to merge 1 commit intomainfrom
Conversation
Remove the unused announcement banner height constant left after the inline banner refactor.
❌ Deploy Preview for unsigned-char failed.
|
✅ Deploy Preview for char-cli-web canceled.
|
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused announcement banner height constant left after the inline banner refactor.
Note
Low Risk
Pure cleanup removing an unused constant; no runtime behavior changes expected.
Overview
Removes the stale, unused
ANNOUNCEMENT_BAR_HEIGHTconstant fromapps/web/src/routes/_view/route.tsx(announcement banner code cleanup after the inline banner refactor).Reviewed by Cursor Bugbot for commit e8922e4. Bugbot is set up for automated code reviews on this repo. Configure here.