fix(desktop): show app details in mic ignore prompt#5288
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7f53430. Configure here.
Use detected app names and footer icons in mic notification ignore prompts, and render footer icons in compact macOS notifications.
ComputelessComputer
force-pushed
the
fix/mic-notification-ignore-app
branch
from
7f53430 to
a77ad36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use detected app names and footer icons in mic notification ignore prompts, and render footer icons in compact macOS notifications.
Note
Medium Risk
Changes the cross-language notification payload schema (
NotificationFooter) and macOS rendering to support footer icons; regressions would affect notification display/serialization across JS/Rust/Swift.Overview
Mic-detected notifications now build a more specific “ignore” prompt using detected app names (e.g.,
Ignore Zoom?,Ignore A and B?, etc.) and dedupe/filter ignorable apps more robustly (excludingpid:entries).Adds
iconsupport toNotificationFooteracross the Rust interface, generated JS bindings, and macOS Swift models, and updates the macOS compact notification UI to render the footer icon (without forcing a default fallback icon when omitted).Reviewed by Cursor Bugbot for commit a77ad36. Bugbot is set up for automated code reviews on this repo. Configure here.