Open
Conversation
✅ Deploy Preview for char-cli-web canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
❌ Deploy Preview for unsigned-char failed.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix prepared fixes for both issues found in the latest run.
- ✅ Fixed: Fixed node count in stripWelcome risks silent data loss
- Replaced hardcoded node count with separator-based search that handles user edits to welcome content structure, preventing data loss from incorrect slicing.
- ✅ Fixed: Entire welcome-note.tsx file is unused dead code
- Deleted the unused welcome-note.tsx file (265 lines) which was never imported anywhere in the codebase.
Or push these changes by commenting:
@cursor push ec04264052
Preview (fastrepl/char@ec04264052)
diff --git a/apps/desktop/src/main2/home/note-editor.tsx b/apps/desktop/src/main2/home/note-editor.tsx
--- a/apps/desktop/src/main2/home/note-editor.tsx
+++ b/apps/desktop/src/main2/home/note-editor.tsx
@@ -170,28 +170,61 @@
return JSON.stringify(firstContentNode) === JSON.stringify(firstWelcomeNode);
}
-const WELCOME_NODE_COUNT = (welcomeContent.content?.length ?? 0) + 1; // +1 for separator paragraph
+const WELCOME_SEPARATOR_NODE = { type: "paragraph" };
function prependWelcome(content: JSONContent): JSONContent {
const welcomeNodes = welcomeContent.content ?? [];
const existingNodes = content.content ?? [];
return {
type: "doc",
- content: [...welcomeNodes, { type: "paragraph" }, ...existingNodes],
+ content: [...welcomeNodes, WELCOME_SEPARATOR_NODE, ...existingNodes],
};
}
function stripWelcome(content: JSONContent): JSONContent {
- let result = content;
- while (hasWelcomeContent(result)) {
- const nodes = result.content ?? [];
- const remaining = nodes.slice(WELCOME_NODE_COUNT);
- result = {
+ const nodes = content.content ?? [];
+ if (!hasWelcomeContent(content)) {
+ return content;
+ }
+
+ // Find the separator paragraph (empty paragraph after welcome content)
+ // and strip everything up to and including it
+ const welcomeNodesExpectedCount = welcomeContent.content?.length ?? 0;
+
+ // Look for the separator within a reasonable range (expected position +/- 5 nodes)
+ // to handle cases where user edited the welcome content
+ const searchStart = Math.max(0, welcomeNodesExpectedCount - 5);
+ const searchEnd = Math.min(nodes.length, welcomeNodesExpectedCount + 6);
+
+ let separatorIndex = -1;
+ for (let i = searchStart; i < searchEnd; i++) {
+ const node = nodes[i];
+ if (
+ node.type === "paragraph" &&
+ (!node.content || node.content.length === 0)
+ ) {
+ separatorIndex = i;
+ break;
+ }
+ }
+
+ // If we found the separator, strip up to and including it
+ if (separatorIndex >= 0) {
+ const remaining = nodes.slice(separatorIndex + 1);
+ return {
type: "doc",
content: remaining.length > 0 ? remaining : [{ type: "paragraph" }],
};
}
- return result;
+
+ // Fallback: if no separator found but welcome content detected,
+ // strip based on expected count to avoid infinite loop
+ const expectedCount = (welcomeContent.content?.length ?? 0) + 1;
+ const remaining = nodes.slice(expectedCount);
+ return {
+ type: "doc",
+ content: remaining.length > 0 ? remaining : [{ type: "paragraph" }],
+ };
}
export function DailyNoteEditor({
diff --git a/apps/desktop/src/main2/home/welcome-note.tsx b/apps/desktop/src/main2/home/welcome-note.tsx
deleted file mode 100644
--- a/apps/desktop/src/main2/home/welcome-note.tsx
+++ /dev/null
@@ -1,265 +1,0 @@
-import "./note-editor.css";
-
-import { useCallback, useRef } from "react";
-
-import { parseJsonContent } from "@hypr/tiptap/shared";
-
-import {
- type JSONContent,
- NoteEditor,
- type NoteEditorRef,
-} from "~/editor/session";
-import * as main from "~/store/tinybase/store/main";
-
-const WELCOME_ROW_ID = "welcome";
-
-const welcomeContent: JSONContent = {
- type: "doc",
- content: [
- {
- type: "heading",
- attrs: { level: 2 },
- content: [{ type: "text", text: "This is your daily notes" }],
- },
- {
- type: "paragraph",
- content: [
- {
- type: "text",
- text: "Every day you get a fresh note for your task, ideas and meetings \u2014 write it any way you want and build your own workflow. Char took all context around your work and help you to fill your day.",
- },
- ],
- },
- {
- type: "heading",
- attrs: { level: 2 },
- content: [{ type: "text", text: "Create lists, tasks and mentions" }],
- },
- {
- type: "taskList",
- content: [
- {
- type: "taskItem",
- attrs: { checked: false },
- content: [
- {
- type: "paragraph",
- content: [
- {
- type: "text",
- text: "You can create todo lists there. Try to type ",
- },
- { type: "text", marks: [{ type: "code" }], text: "-[]" },
- { type: "text", text: " or just use " },
- { type: "text", marks: [{ type: "code" }], text: "/" },
- { type: "text", text: " for command" },
- ],
- },
- ],
- },
- ],
- },
- {
- type: "bulletList",
- content: [
- {
- type: "listItem",
- content: [
- {
- type: "paragraph",
- content: [
- { type: "text", text: "Write bullet lists and numbered one." },
- ],
- },
- ],
- },
- ],
- },
- {
- type: "heading",
- attrs: { level: 2 },
- content: [{ type: "text", text: "Check your meetings there" }],
- },
- {
- type: "paragraph",
- content: [
- {
- type: "text",
- text: "All meetings from calendar appears in your daily notes. You can write notes inside the meetings or create new note",
- },
- ],
- },
- {
- type: "session",
- attrs: { sessionId: "welcome-demo", status: null, checked: null },
- content: [
- {
- type: "paragraph",
- content: [{ type: "text", text: "This is dummy meeting" }],
- },
- ],
- },
- {
- type: "paragraph",
- content: [
- {
- type: "text",
- marks: [{ type: "italic" }],
- text: "Create a new note by pressing ",
- },
- {
- type: "text",
- marks: [{ type: "code" }],
- text: "new recording",
- },
- {
- type: "text",
- marks: [{ type: "italic" }],
- text: " button",
- },
- ],
- },
- {
- type: "heading",
- attrs: { level: 2 },
- content: [{ type: "text", text: "Make this fully yourself with AI" }],
- },
- {
- type: "paragraph",
- content: [
- {
- type: "text",
- text: "Get the tasks done right from Daily Notes with multiple ",
- },
- {
- type: "text",
- marks: [
- {
- type: "link",
- attrs: { href: "https://char.com/docs/integrations" },
- },
- ],
- text: "integrations",
- },
- { type: "text", text: " Char has" },
- ],
- },
- {
- type: "heading",
- attrs: { level: 2 },
- content: [{ type: "text", text: "And much more" }],
- },
- {
- type: "paragraph",
- content: [
- { type: "text", text: "Read " },
- {
- type: "text",
- marks: [{ type: "link", attrs: { href: "https://char.com/docs" } }],
- text: "docs",
- },
- {
- type: "text",
- text: " to integrate all features in your workflow. Join us on ",
- },
- {
- type: "text",
- marks: [{ type: "link", attrs: { href: "https://x.com/char" } }],
- text: "X",
- },
- { type: "text", text: " or " },
- {
- type: "text",
- marks: [{ type: "link", attrs: { href: "https://discord.gg/char" } }],
- text: "Discord",
- },
- { type: "text", text: " to get the last updates" },
- ],
- },
- {
- type: "heading",
- attrs: { level: 2 },
- content: [
- { type: "text", text: "All your previous notes perfectly fine" },
- ],
- },
- {
- type: "paragraph",
- content: [
- {
- type: "text",
- text: "They are available through previous Daily Notes, search and folder where you keep them, nothing changes",
- },
- ],
- },
- ],
-};
-
-function readSavedContent(
- store: NonNullable<ReturnType<typeof main.UI.useStore>>,
-): JSONContent | null {
- const cell = store.getCell("daily_notes", WELCOME_ROW_ID, "content");
- if (typeof cell !== "string" || cell === "") return null;
- return parseJsonContent(cell) ?? null;
-}
-
-export function WelcomeNote({ onDismiss }: { onDismiss: () => void }) {
- const store = main.UI.useStore(main.STORE_ID);
- const editorRef = useRef<NoteEditorRef>(null);
-
- const initialContentRef = useRef<JSONContent | null>(null);
- if (!initialContentRef.current && store) {
- initialContentRef.current = readSavedContent(store) ?? welcomeContent;
- }
-
- const persistWelcomeNote = main.UI.useSetPartialRowCallback(
- "daily_notes",
- WELCOME_ROW_ID,
- (input: JSONContent) => ({
- content: JSON.stringify(input),
- date: WELCOME_ROW_ID,
- }),
- [],
- main.STORE_ID,
- );
-
- const handleChange = useCallback(
- (input: JSONContent) => {
- persistWelcomeNote(input);
- },
- [persistWelcomeNote],
- );
-
- if (!initialContentRef.current) {
- return null;
- }
-
- return (
- <div>
- <div className="flex items-center gap-3 px-6 pt-6 pb-3">
- <h2 className="text-xl font-semibold text-neutral-900">
- Welcome to Char
- </h2>
- </div>
-
- <div className="main2-daily-note-editor px-6">
- <NoteEditor
- ref={editorRef}
- key="daily-welcome"
- initialContent={initialContentRef.current}
- handleChange={handleChange}
- linkedItemOpenBehavior="new"
- />
- </div>
-
- <div className="px-6 pt-4 pb-6">
- <button
- onClick={onDismiss}
- className="rounded-full bg-neutral-900 px-5 py-2.5 text-sm font-medium text-white transition-colors hover:bg-neutral-800"
- >
- Start to use your Char
- </button>
- </div>
- </div>
- );
-}
\ No newline at end of fileThis Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3129e3a. Configure here.
| }; | ||
| } | ||
| return result; | ||
| } |
There was a problem hiding this comment.
Fixed node count in stripWelcome risks silent data loss
High Severity
stripWelcome uses a hardcoded WELCOME_NODE_COUNT (9) to slice nodes, but the welcome content is rendered in a fully editable ProseMirror editor with no read-only protection. If a user deletes a welcome paragraph or presses Enter to split a node, the actual node count drifts from the constant. When handleChange calls stripWelcome on every keystroke, nodes.slice(9) will silently discard the user's first real content nodes (if welcome nodes were removed) or leak welcome remnants into persisted data (if nodes were added). Similarly, if the user edits the first heading text, hasWelcomeContent returns false and the entire welcome content gets permanently persisted into the daily note.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 3129e3a. Configure here.
| </div> | ||
| </div> | ||
| ); | ||
| } |
There was a problem hiding this comment.
Entire welcome-note.tsx file is unused dead code
Medium Severity
welcome-note.tsx exports WelcomeNote but it is never imported anywhere in the codebase. It contains a separate 265-line implementation with its own welcomeContent and persistence logic (writing to a "welcome" row in daily_notes), which differs entirely from the approach actually used via welcome-content.ts and note-editor.tsx. This appears to be an abandoned earlier approach that was accidentally included in the PR.
Reviewed by Cursor Bugbot for commit 3129e3a. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
welcome screen in the app that tells user about what they can do and how it works
Note
Medium Risk
Introduces dynamic insertion/removal of a welcome block into the daily note editor and persists dismissal state in
localStorage, which could affect note content serialization and user data if the strip/prepend logic misbehaves.Overview
Adds a first-day Daily Notes welcome experience that conditionally shows a predefined
welcomeContentat the top of today’s note, with a “Clear welcome message” control and persisted state viaWELCOME_DATE_KEY/WELCOME_DISMISSED_KEYinlocalStorage.Updates
DailyNoteEditorto prepend the welcome nodes for display but strip them before saving, including cleanup for any previously persisted welcome content, and adds in-editor handling forchar://settings/*links to open the corresponding settings tab.Includes styling tweaks for the daily note editor (headings, task list spacing, session icon alignment,
text-box-trim) plus minor spacing adjustments in session/task node views, and adds devtools/debug actions to reset the welcome state.Reviewed by Cursor Bugbot for commit 3a8ff26. Bugbot is set up for automated code reviews on this repo. Configure here.