Upgrade Rails 7.1 → 8.0 (#358)

* Bump Rails 7.1.5.1 → 7.1.6

* Switch show_exceptions to symbol value for Rails 7.2

Rails 7.2 changes config.action_dispatch.show_exceptions from a
boolean to a symbol. Boolean values stop working at the 7.2 bump.

  - true       -> :all
  - false      -> :none
  - new option -> :rescuable (raise non-rescuable, render rescuable)

The test environment used `false` (raise everything). The 1:1
replacement is :none. Symbol form already works on 7.1, so this is
a direct rewrite with no dual-boot conditional needed.

Ref: https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#config-action-dispatch-show-exceptions

* Drop Rails.application.secrets in favor of credentials/ENV

Rails 7.2 removes Rails.application.secrets entirely. Anything that
relied on config/secrets.yml stops working at the bump. Currently the
file only carries secret_key_base, which Rails resolves through this
chain (in order):

  1. Rails.application.credentials.secret_key_base
  2. ENV["SECRET_KEY_BASE"]
  3. tmp/local_secret.txt (dev/test auto-generated)

Production already uses ENV["SECRET_KEY_BASE"] (unchanged). Dev/test
fall through to tmp/local_secret.txt automatically, so deleting
secrets.yml is safe.

Also drops config.read_encrypted_secrets = true from production.rb,
which is a no-op in 7.2 and only ever applied to the legacy
secrets.yml.enc workflow.

Ref: https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#rails-application-secrets-removal

* Bump rspec-rails ~> 6.0.3 → ~> 6.1 for fixture_paths support

Rails 7.2 deprecates fixture_path (singular) in favor of
fixture_paths (plural array). The new API exists in Rails 7.1+,
but rspec-rails surfaces it via config.fixture_paths only from
6.1.0 onward — 6.0.x still expects fixture_path.

Bumping the floor to 6.1 unblocks the fixture_paths rewrite that
follows in the next commit. 6.1.5 resolves cleanly on both
sides of the dual-boot pair (7.1.6 and 7.2.3) with no other
gem changes pulled in beyond the rspec-rails sub-gems on the
.next side.

* Rename fixture_path → fixture_paths in rspec config

Rails 7.2 deprecates the singular fixture_path setter on
ActiveSupport::TestCase. rspec-rails 6.1+ exposes the plural
form, which takes an array of paths and is the long-term API
on both 7.1 and 7.2. Direct rewrite — no NextRails.next? branch
needed, and no behavior change since we still point at a single
spec/fixtures directory.

Ref: https://github.com/rspec/rspec-rails/blob/main/Changelog.md#610--2023-11-21

* Bump database_cleaner-active_record 2.1.0 → 2.2.2 for Rails 7.2

database_cleaner-active_record 2.1.x calls AR connection
adapter#schema_migration, which Rails 7.2 removed in favor of an
internal-pool-based API. The 2.1.x suite errors out on boot
under 7.2 with:

  NoMethodError: undefined method `schema_migration' for
  #<ActiveRecord::ConnectionAdapters::PostgreSQLAdapter ...>

2.2.0 reworked the cleanup to use the new connection API. 2.2.2 is
the latest patch and resolves cleanly on both 7.1.6 and 7.2.3.

Doing the bump as its own commit so the Rails version flip in the
next commit is isolated to the Gemfile constraint change.

Ref: https://github.com/DatabaseCleaner/database_cleaner-active_record/blob/main/CHANGELOG.md

* Upgrade Rails 7.1.6 → 7.2.3.1

Flips the Gemfile constraint from ~> 7.1.0 to ~> 7.2.0 and
collapses the dual-boot if/else into a single line, since both
sides of the dual-boot pair now point at 7.2 anyway.

The next? helper (Gemfile lines 3-5) and the Gemfile.next symlink
stay in place. They will be retired in a follow-up cleanup pass
once 7.2 ships, per the dual-boot teardown checklist — keeping
them now keeps build-rails-next in CI as a sanity check on the
exact same constraints as build-rails-current.

All fix-before-bump items were addressed in earlier commits in
this branch:

  - show_exceptions symbol value
  - Rails.application.secrets removal
  - rspec-rails fixture_paths support
  - database_cleaner-active_record schema_migration compat

Test suite is 204/204 green on 7.2.3.1.

* Bump jbuilder ~> 2.5 → ~> 2.13 for Rails 8 compat

jbuilder 2.11.x calls require "active_support/proxy_object" at
load time. proxy_object was deprecated in Rails 5 and removed in
Rails 8.0, so the require raises LoadError the moment Bundler
runs Bundler.require for the :default group:

  LoadError: cannot load such file -- active_support/proxy_object
    config/application.rb:7:in `<top (required)>'

jbuilder 2.12 dropped the require (jbuilder commit b8e2d8f),
2.13 added explicit Rails 8 support. Bumping the floor to 2.13
resolves cleanly on both 7.2 (current) and 8.0 (next), so this
sits as a prereq before the Rails version flip.

Conservative resolution kept all other gems pinned.

Ref: rails/jbuilder#580

* Upgrade Rails 7.2.3.1 → 8.0.5

Flips the Gemfile constraint from ~> 7.2.0 to ~> 8.0.0 and
collapses the dual-boot if/else into a single line. Both sides
of the dual-boot pair (Gemfile and Gemfile.next via symlink) now
target 8.0.

Detection against the 8.0 pattern set surfaced no fix-before-bump
items in our codebase: enum is unused, no removed AR config keys,
no routes-array usage, no SCHEMA_CACHE env var, no Benchmark.ms,
Ruby 3.2.3 already meets the 3.2.0 floor.

Sprockets stays — it still works at 8.0 (just no longer the new-
app default). Migration to Propshaft is a separate, optional
concern.

The only prereq surfaced by booting the test suite under 8.0 was
jbuilder still requiring active_support/proxy_object; addressed
in the previous commit.

Test suite is 204/204 green on 8.0.5.

Deferred to the 8.0 → 8.1 hop (per skill rules — future-version
runtime warnings are not fix-before-bump for the current hop):

  - to_time timezone behavior
    (config.active_support.to_time_preserves_timezone = :zone)

Author: JuanVqz

Gemfile

@@ -11,15 +11,7 @@ git_source(:github) do |repo_name|
   "https://github.com/#{repo_name}.git"
 end
 
-if next?
-  # using the 7-0-stable branch for the time being until the fix is merged into main
-  # to make it work with ruby 3.1
-  # read more about it here: https://github.com/rails/rails/issues/43998,
-  # and here: https://gist.github.com/claudiug/bdc2fb70b10d19513208c816588aed92
-  gem "rails", "~> 7.2.0"
-else
-  gem "rails", "~> 7.1.0"
-end
+gem "rails", "~> 8.0.0"
 # Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
 
 gem "bootstrap-sass", "3.4.1"
@@ -40,7 +32,7 @@ gem "redcarpet", "~> 3.5.1"
 # Turbolinks makes navigating your web application faster. Read more: https://github.com/turbolinks/turbolinks
 gem "turbolinks", "~> 5"
 # Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder
-gem "jbuilder", "~> 2.5"
+gem "jbuilder", "~> 2.13"
 # Use Redis adapter to run Action Cable in production
 # gem 'redis', '~> 3.0'
 # Use ActiveModel has_secure_password
@@ -73,7 +65,7 @@ group :development, :test do
   # Call 'byebug' anywhere in the code to stop execution and get a debugger console
   gem "byebug", platforms: [:mri, :mingw, :x64_mingw]
   # Adds support for Capybara system testing and selenium driver
-  gem "rspec-rails", "~> 6.0.3"
+  gem "rspec-rails", "~> 6.1"
   gem "faker"
   gem "shoulda-matchers", "~> 3.1"
   gem "rails-controller-testing"

Gemfile.lock

@@ -10,83 +10,77 @@ GIT
 GEM
   remote: https://rubygems.org/
   specs:
-    actioncable (7.1.5.1)
-      actionpack (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
+    actioncable (8.0.5)
+      actionpack (= 8.0.5)
+      activesupport (= 8.0.5)
       nio4r (~> 2.0)
       websocket-driver (>= 0.6.1)
       zeitwerk (~> 2.6)
-    actionmailbox (7.1.5.1)
-      actionpack (= 7.1.5.1)
-      activejob (= 7.1.5.1)
-      activerecord (= 7.1.5.1)
-      activestorage (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
-      mail (>= 2.7.1)
-      net-imap
-      net-pop
-      net-smtp
-    actionmailer (7.1.5.1)
-      actionpack (= 7.1.5.1)
-      actionview (= 7.1.5.1)
-      activejob (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
-      mail (~> 2.5, >= 2.5.4)
-      net-imap
-      net-pop
-      net-smtp
+    actionmailbox (8.0.5)
+      actionpack (= 8.0.5)
+      activejob (= 8.0.5)
+      activerecord (= 8.0.5)
+      activestorage (= 8.0.5)
+      activesupport (= 8.0.5)
+      mail (>= 2.8.0)
+    actionmailer (8.0.5)
+      actionpack (= 8.0.5)
+      actionview (= 8.0.5)
+      activejob (= 8.0.5)
+      activesupport (= 8.0.5)
+      mail (>= 2.8.0)
       rails-dom-testing (~> 2.2)
-    actionpack (7.1.5.1)
-      actionview (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
+    actionpack (8.0.5)
+      actionview (= 8.0.5)
+      activesupport (= 8.0.5)
       nokogiri (>= 1.8.5)
-      racc
       rack (>= 2.2.4)
       rack-session (>= 1.0.1)
       rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.2)
       rails-html-sanitizer (~> 1.6)
-    actiontext (7.1.5.1)
-      actionpack (= 7.1.5.1)
-      activerecord (= 7.1.5.1)
-      activestorage (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
+      useragent (~> 0.16)
+    actiontext (8.0.5)
+      actionpack (= 8.0.5)
+      activerecord (= 8.0.5)
+      activestorage (= 8.0.5)
+      activesupport (= 8.0.5)
       globalid (>= 0.6.0)
       nokogiri (>= 1.8.5)
-    actionview (7.1.5.1)
-      activesupport (= 7.1.5.1)
+    actionview (8.0.5)
+      activesupport (= 8.0.5)
       builder (~> 3.1)
       erubi (~> 1.11)
       rails-dom-testing (~> 2.2)
       rails-html-sanitizer (~> 1.6)
-    activejob (7.1.5.1)
-      activesupport (= 7.1.5.1)
+    activejob (8.0.5)
+      activesupport (= 8.0.5)
       globalid (>= 0.3.6)
-    activemodel (7.1.5.1)
-      activesupport (= 7.1.5.1)
-    activerecord (7.1.5.1)
-      activemodel (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
+    activemodel (8.0.5)
+      activesupport (= 8.0.5)
+    activerecord (8.0.5)
+      activemodel (= 8.0.5)
+      activesupport (= 8.0.5)
       timeout (>= 0.4.0)
-    activestorage (7.1.5.1)
-      actionpack (= 7.1.5.1)
-      activejob (= 7.1.5.1)
-      activerecord (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
+    activestorage (8.0.5)
+      actionpack (= 8.0.5)
+      activejob (= 8.0.5)
+      activerecord (= 8.0.5)
+      activesupport (= 8.0.5)
       marcel (~> 1.0)
-    activesupport (7.1.5.1)
+    activesupport (8.0.5)
       base64
       benchmark (>= 0.3)
       bigdecimal
-      concurrent-ruby (~> 1.0, >= 1.0.2)
+      concurrent-ruby (~> 1.0, >= 1.3.1)
       connection_pool (>= 2.2.5)
       drb
       i18n (>= 1.6, < 2)
       logger (>= 1.4.2)
       minitest (>= 5.1)
-      mutex_m
       securerandom (>= 0.3)
-      tzinfo (~> 2.0)
+      tzinfo (~> 2.0, >= 2.0.5)
+      uri (>= 0.13.1)
     acts_as_list (1.1.0)
       activerecord (>= 4.2)
     addressable (2.8.5)
@@ -126,9 +120,9 @@ GEM
     concurrent-ruby (1.3.5)
     connection_pool (2.5.3)
     crass (1.0.6)
-    database_cleaner-active_record (2.1.0)
+    database_cleaner-active_record (2.2.2)
       activerecord (>= 5.a)
-      database_cleaner-core (~> 2.0.0)
+      database_cleaner-core (~> 2.0)
     database_cleaner-core (2.0.1)
     date (3.4.1)
     devise (4.9.4)
@@ -137,7 +131,7 @@ GEM
       railties (>= 4.1.0)
       responders
       warden (~> 1.2.3)
-    diff-lcs (1.5.0)
+    diff-lcs (1.6.2)
     docile (1.4.0)
     dotenv (2.8.1)
     dotenv-rails (2.8.1)
@@ -161,7 +155,7 @@ GEM
     faraday-net_http (3.4.0)
       net-http (>= 0.5.0)
     ffi (1.16.3)
-    globalid (1.2.1)
+    globalid (1.3.0)
       activesupport (>= 6.1)
     hashie (5.0.0)
     i18n (1.14.7)
@@ -171,9 +165,9 @@ GEM
       pp (>= 0.6.0)
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
-    jbuilder (2.11.5)
-      actionview (>= 5.0.0)
-      activesupport (>= 5.0.0)
+    jbuilder (2.14.1)
+      actionview (>= 7.0.0)
+      activesupport (>= 7.0.0)
     jquery-rails (4.6.0)
       rails-dom-testing (>= 1, < 3)
       railties (>= 4.2.0)
@@ -197,12 +191,13 @@ GEM
     madmin (1.2.8)
       pagy (>= 3.5)
       rails (>= 6.0.3)
-    mail (2.8.1)
+    mail (2.9.0)
+      logger
       mini_mime (>= 0.1.1)
       net-imap
       net-pop
       net-smtp
-    marcel (1.0.4)
+    marcel (1.1.0)
     matrix (0.4.2)
     mimemagic (0.3.10)
       nokogiri (~> 1)
@@ -211,10 +206,9 @@ GEM
     minitest (5.25.5)
     multi_xml (0.7.2)
       bigdecimal (~> 3.1)
-    mutex_m (0.3.0)
     net-http (0.6.0)
       uri
-    net-imap (0.5.8)
+    net-imap (0.6.4)
       date
       net-protocol
     net-pop (0.1.2)
@@ -292,20 +286,20 @@ GEM
     rackup (1.0.1)
       rack (< 3)
       webrick
-    rails (7.1.5.1)
-      actioncable (= 7.1.5.1)
-      actionmailbox (= 7.1.5.1)
-      actionmailer (= 7.1.5.1)
-      actionpack (= 7.1.5.1)
-      actiontext (= 7.1.5.1)
-      actionview (= 7.1.5.1)
-      activejob (= 7.1.5.1)
-      activemodel (= 7.1.5.1)
-      activerecord (= 7.1.5.1)
-      activestorage (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
+    rails (8.0.5)
+      actioncable (= 8.0.5)
+      actionmailbox (= 8.0.5)
+      actionmailer (= 8.0.5)
+      actionpack (= 8.0.5)
+      actiontext (= 8.0.5)
+      actionview (= 8.0.5)
+      activejob (= 8.0.5)
+      activemodel (= 8.0.5)
+      activerecord (= 8.0.5)
+      activestorage (= 8.0.5)
+      activesupport (= 8.0.5)
       bundler (>= 1.15.0)
-      railties (= 7.1.5.1)
+      railties (= 8.0.5)
     rails-controller-testing (1.0.5)
       actionpack (>= 5.0.1.rc1)
       actionview (>= 5.0.1.rc1)
@@ -317,13 +311,14 @@ GEM
     rails-html-sanitizer (1.6.2)
       loofah (~> 2.21)
       nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0)
-    railties (7.1.5.1)
-      actionpack (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
-      irb
+    railties (8.0.5)
+      actionpack (= 8.0.5)
+      activesupport (= 8.0.5)
+      irb (~> 1.13)
       rackup (>= 1.0.0)
       rake (>= 12.2)
       thor (~> 1.0, >= 1.2.2)
+      tsort (>= 0.2)
       zeitwerk (~> 2.6)
     rainbow (3.1.1)
     rake (13.3.0)
@@ -342,23 +337,23 @@ GEM
       actionpack (>= 5.2)
       railties (>= 5.2)
     rexml (3.2.6)
-    rspec-core (3.12.2)
-      rspec-support (~> 3.12.0)
-    rspec-expectations (3.12.3)
+    rspec-core (3.13.6)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.12.0)
-    rspec-mocks (3.12.6)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.8)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.12.0)
-    rspec-rails (6.0.3)
+      rspec-support (~> 3.13.0)
+    rspec-rails (6.1.5)
       actionpack (>= 6.1)
       activesupport (>= 6.1)
       railties (>= 6.1)
-      rspec-core (~> 3.12)
-      rspec-expectations (~> 3.12)
-      rspec-mocks (~> 3.12)
-      rspec-support (~> 3.12)
-    rspec-support (3.12.1)
+      rspec-core (~> 3.13)
+      rspec-expectations (~> 3.13)
+      rspec-mocks (~> 3.13)
+      rspec-support (~> 3.13)
+    rspec-support (3.13.7)
     rubocop (1.56.4)
       base64 (~> 0.1.1)
       json (~> 2.3)
@@ -442,13 +437,15 @@ GEM
     thor (1.3.2)
     tilt (2.3.0)
     timeout (0.4.3)
+    tsort (0.2.0)
     turbolinks (5.2.1)
       turbolinks-source (~> 5.2)
     turbolinks-source (5.2.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.5.0)
     uri (1.0.3)
+    useragent (0.16.11)
     version_gem (1.1.8)
     warden (1.2.9)
       rack (>= 2.0.9)
@@ -491,7 +488,7 @@ DEPENDENCIES
   dotenv-rails
   factory_bot_rails
   faker
-  jbuilder (~> 2.5)
+  jbuilder (~> 2.13)
   jquery-rails
   jquery-ui-rails (~> 6.0)
   listen (~> 3.7)
@@ -505,11 +502,11 @@ DEPENDENCIES
   puma (~> 6.5)
   pundit (~> 2.2)
   rack-mini-profiler
-  rails (~> 7.1.0)
+  rails (~> 8.0.0)
   rails-controller-testing
   recursive-open-struct
   redcarpet (~> 3.5.1)
-  rspec-rails (~> 6.0.3)
+  rspec-rails (~> 6.1)
   sass-rails (~> 5.0)
   sentry-rails
   sentry-ruby