Skip to content

Commit f7f4c17

Browse files
FionaDLABizzinotto
authored andcommitted
IIRR-18 Update with rubocop thoughts and ideas
1 parent 6d3083d commit f7f4c17

File tree

2 files changed

+10
-14
lines changed

2 files changed

+10
-14
lines changed

app/jobs/weekly_leaderboard_job.rb

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,21 +8,21 @@ def perform
88
leaderboard_data = Answer
99
.where(created_at: start_time..end_time, is_correct: true)
1010
.group(:user_id)
11-
.order(Arel.sql('COUNT(*) DESC'))
11+
.order(Arel.sql("COUNT(*) DESC"))
1212
.count
1313

1414
return if leaderboard_data.empty?
1515

1616
Server.all.each do |server|
1717
channel = server.channel
1818
bot.send_message(
19-
channel.channel_id,
20-
"",
21-
false,
19+
channel.channel_id,
20+
"",
21+
false,
2222
leaderboard_embed(leaderboard_data),
23-
nil,
24-
nil,
25-
nil,
23+
nil,
24+
nil,
25+
nil,
2626
nil) if channel
2727
end
2828
end
@@ -38,7 +38,7 @@ def leaderboard_embed(leaderboard_data)
3838

3939
# Group leaderboard data by score
4040
grouped_by_score = leaderboard_data.group_by { |user_id, score| score }
41-
41+
4242
previous_score = nil
4343
rank = 0
4444
displayed_count = 0
@@ -61,5 +61,3 @@ def leaderboard_embed(leaderboard_data)
6161
embed
6262
end
6363
end
64-
65-

db/seeds.rb

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,8 @@
3333
Answer.create!(
3434
user_id: user.id,
3535
puzzle_id: Puzzle.all.sample.id,
36-
choice: ["ruby", "rails"].sample,
37-
is_correct: [true, false].sample
36+
choice: [ "ruby", "rails" ].sample,
37+
is_correct: [ true, false ].sample
3838
)
3939
end
4040
end
41-
42-

0 commit comments

Comments
 (0)