Merged
Conversation
JuanVqz
commented
Oct 8, 2025
| respond_to do |format| | ||
| format.turbo_stream { render turbo_stream: turbo_stream.replace(@puzzle, partial: "puzzles/form", locals: { puzzle: @puzzle }) } | ||
| else | ||
| format.turbo_stream { render turbo_stream: turbo_stream.replace("modal", partial: "puzzles/edit_modal", locals: { puzzle: @puzzle }), status: :unprocessable_entity } |
Member
Author
There was a problem hiding this comment.
This is the reason the errors didn't show up at Fiona's PR; the first element should be the turbo frame's name.
Also had to move the edit.html.erb view content into a partial _edit_modal.html.erb because this turbo stream needed it to render the errors
JuanVqz
force-pushed
the
add-puzzle-validations
branch
from
523b1bf to
a7bda7b
Compare
mateusdeap
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Inspired by #35 to know more about turbo and the need to add validations, I decided to contribute by adding the validation on top of Fiona's PR.