Merged
Conversation
etagwerker
reviewed
Oct 18, 2025
Member
etagwerker
left a comment
etagwerker
left a comment
There was a problem hiding this comment.
@julioalucero This looks good! Could you please use this style guide: https://fastruby.github.io/styleguide ?
julioalucero
force-pushed
the
update-homepage-with-rules
branch
from
bce41a4 to
6872e91
Compare
julioalucero
commented
Oct 30, 2025
| gem "slack-ruby-client", ">= 2.4.0" | ||
|
|
||
| gem "fastruby-styleguide", github: "fastruby/styleguide", branch: "gh-pages" | ||
|
|
Member
Author
There was a problem hiding this comment.
We have a few dependencies, so Gemfile.lock will looks bigger
julioalucero
commented
Oct 30, 2025
| gem "dotenv-rails" | ||
|
|
||
| gem "propshaft" | ||
| gem "dartsass-rails" |
Member
Author
There was a problem hiding this comment.
Member
Author
|
@etagwerker it is ready to review. It is posible that the admin looks a bit different given that now we are using the FastRuby Styleguide. |
etagwerker
approved these changes
Nov 11, 2025
Member
etagwerker
left a comment
etagwerker
left a comment
There was a problem hiding this comment.
@julioalucero Looks good, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fastruby/styleguideand compile SCSS viadartsass-rails.Propshaft/importmapas-is; add minimalSprocketsconfig to avoid gem warnings.Changes
fastruby-styleguideanddartsass-rails.manifest.jsandassets.rb(no functional change).https://ruby-or-rails.fastruby.io/ homepage:
It resolves #19