qwerty

Author: JuanVqz

lib/skunk/cli/application.rb

@@ -31,10 +31,10 @@ def execute
         command = Skunk::CommandFactory.create(@parsed_options)
         reporter = command.execute
 
-        print(reporter.status_message)
+        $stdout.puts(reporter.status_message)
         if command.sharing?
           share_status_message = command.share(reporter)
-          print(share_status_message)
+          $stdout.puts(share_status_message)
         end
 
         reporter.status
@@ -49,10 +49,6 @@ def warn_coverage_info
         warn "warning: Couldn't find coverage info at #{COVERAGE_FILE}."
         warn "warning: Having no coverage metrics will make your SkunkScore worse."
       end
-
-      def print(message)
-        $stdout.puts(message)
-      end
     end
   end
 end

lib/skunk/commands/status_sharer.rb

@@ -35,7 +35,7 @@ def share
 
       # :reek:UtilityFunction
       def base_url
-        ENV["SHARE_URL"] || DEFAULT_URL
+        @base_url ||= ENV["SHARE_URL"] || DEFAULT_URL
       end
 
       def json_summary
@@ -73,11 +73,11 @@ def share_enabled?
 
       # @return [Boolean] Check if share URL is empty
       def share_url_empty?
-        share_url == ""
+        share_url.empty?
       end
 
       def share_url
-        ENV["SHARE_URL"].to_s
+        @share_url ||= ENV["SHARE_URL"].to_s
       end
 
       def payload

lib/skunk/config.rb

@@ -55,7 +55,8 @@ def root
     end
 
     def root=(path)
-      @root = path.nil? || path.to_s.empty? ? nil : File.expand_path(path.to_s)
+      path_str = path.to_s
+      @root = path_str.empty? ? nil : File.expand_path(path_str)
     end
 
     # Add a format to the existing list

samples/rubycritic/compare/skunk_report.txt

@@ -0,0 +1 @@
+test output

test/lib/skunk/cli/options/argv_test.rb

@@ -13,13 +13,22 @@
     it "sets Skunk::Config.root to the provided path" do
       parser = Skunk::Cli::Options::Argv.new(["--out=tmp/custom"])
       parser.parse
-      _(Skunk::Config.root).must_match(/tmp\/custom$/)
+      _(Skunk::Config.root).must_match(%r{tmp/custom$})
     end
 
     it "defaults to tmp/rubycritic when not provided" do
-      parser = Skunk::Cli::Options::Argv.new([])
-      parser.parse
-      _(Skunk::Config.root).must_match(/tmp\/rubycritic$/)
+      begin
+        prior_root = RubyCritic::Config.root
+        default_root = File.expand_path("tmp/rubycritic_default", Dir.pwd)
+        RubyCritic::Config.root = default_root
+        Skunk::Config.reset
+        parser = Skunk::Cli::Options::Argv.new([])
+        parser.parse
+        _(Skunk::Config.root).must_equal default_root
+      ensure
+        RubyCritic::Config.root = prior_root || default_root
+        Skunk::Config.reset
+      end
     end
   end
 

test/lib/skunk/config_test.rb

@@ -81,7 +81,14 @@ def test_reset
     end
 
     def test_default_root
-      assert_match(/tmp\/rubycritic$/, Config.root)
+      prior_root = RubyCritic::Config.root
+      default_root = File.expand_path("tmp/rubycritic_default", Dir.pwd)
+      RubyCritic::Config.root = default_root
+      Config.reset
+      assert_equal default_root, Config.root
+    ensure
+      RubyCritic::Config.root = prior_root || default_root
+      Config.reset
     end
 
     def test_set_root_expands_path

test/lib/skunk/generators/html/overview_test.rb

@@ -23,4 +23,4 @@ def test_root_directory_uses_skunk_config_root
       end
     end
   end
-end
+end