refactor(config): centralize output path configuration and simplify printing

Move output path configuration to Skunk::Config and remove file output logic from Application#print
Update tests and documentation to reflect changes in output path handling

Even if the default path where the JSON and HTML reports are generated are `tmp/rubycritic` you can now modify them.

Author: JuanVqz

CHANGELOG.md

@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## main [(unreleased)](https://github.com/fastruby/skunk/compare/v0.5.4...HEAD)
 
+* [FEATURE: Indicate `--out PATH` location](https://github.com/fastruby/skunk/pull/131)
 * [FEATURE: Add `--formats` CLI flag to select report formats (json, html, console)](https://github.com/fastruby/skunk/pull/130)
 * [REFACTOR: Move Console Report](https://github.com/fastruby/skunk/pull/128)
 * [BUGFIX: Set the right content type in the share HTTP request](https://github.com/fastruby/skunk/pull/129)

README.md

@@ -65,7 +65,7 @@ Run `skunk -h` to check out the help options:
 ```
 Usage: skunk [options] [paths]
     -b, --branch BRANCH              Set branch to compare
-    -o, --out FILE                   Output report to file
+    -o, --out PATH                   Output report path
     -v, --version                    Show gem's version
     -h, --help                       Show this message
 ```
@@ -127,7 +127,9 @@ To only run skunk on specific folders, pass a list of directories in the command
 
 ### Generate JSON report in background
 
-When the Skunk command is run, it will generate a JSON report file in the `RubyCritic::Config.root` location.
+When the Skunk command is run, it will generate a JSON report file in the configured output path.
+
+Skunk also writes the console report to `skunk_console.txt` under the same output path.
 
 ### Comparing feature branches
 

bin/console

@@ -13,5 +13,6 @@ puts ARGV.inspect
 require "skunk/cli/application"
 require "skunk/config"
 
-Skunk::Config.formats = %i[json console html]
+Skunk::Config.formats = %i[json console html] # supported output formats
+Skunk::Config.root = "tmp/rubycritic"         # default path to store generated JSON and HTML reports.
 Skunk::Cli::Application.new(ARGV).execute

lib/skunk/cli/application.rb

@@ -50,14 +50,8 @@ def warn_coverage_info
         warn "warning: Having no coverage metrics will make your SkunkScore worse."
       end
 
-      # :reek:NilCheck
       def print(message)
-        filename = @parsed_options[:output_filename]
-        if filename.nil?
-          $stdout.puts(message)
-        else
-          File.open(filename, "a") { |file| file << message }
-        end
+        $stdout.puts(message)
       end
     end
   end

lib/skunk/cli/options/argv.rb

@@ -10,59 +10,32 @@ class Options
       # Extends RubyCritic::Cli::Options::Argv to parse a subset of the
       # parameters accepted by RubyCritic
       class Argv < RubyCritic::Cli::Options::Argv
-        # :reek:Attribute
-        attr_accessor :output_filename
-
         def parse
           parser.new do |opts|
             opts.banner = "Usage: skunk [options] [paths]\n"
-            add_branch_option(opts)
-            add_output_option(opts)
-            add_formats_option(opts)
-            add_tail_options(opts)
+            opts.on("-b", "--branch BRANCH", "Set branch to compare") do |branch|
+              self.base_branch = String(branch)
+              set_current_branch
+              self.mode = :compare_branches
+            end
+
+            opts.on("-o", "--out PATH", "Output report path") do |path|
+              Skunk::Config.root = path
+            end
+
+            opts.on("-f", "--formats json,html,console", Array, "Output formats: json,html,console") do |list|
+              Skunk::Config.formats = Array(list).map(&:to_sym)
+            end
+
+            opts.on_tail("-v", "--version", "Show gem's version") do
+              self.mode = :version
+            end
+
+            opts.on_tail("-h", "--help", "Show this message") do
+              self.mode = :help
+            end
           end.parse!(@argv)
         end
-
-        def to_h
-          super.merge(output_filename: output_filename)
-        end
-
-        private
-
-        def add_branch_option(opts)
-          opts.on("-b", "--branch BRANCH", "Set branch to compare") do |branch|
-            self.base_branch = String(branch)
-            set_current_branch
-            self.mode = :compare_branches
-          end
-        end
-
-        def add_output_option(opts)
-          opts.on("-o", "--out FILE", "Output report to file") do |filename|
-            self.output_filename = filename
-          end
-        end
-
-        def add_formats_option(opts)
-          opts.on(
-            "-f",
-            "--formats json,html,console",
-            Array,
-            "Output formats: json,html,console (default: console)"
-          ) do |list|
-            Skunk::Config.formats = Array(list).map(&:to_sym)
-          end
-        end
-
-        def add_tail_options(opts)
-          opts.on_tail("-v", "--version", "Show gem's version") do
-            self.mode = :version
-          end
-
-          opts.on_tail("-h", "--help", "Show this message") do
-            self.mode = :help
-          end
-        end
       end
     end
   end

lib/skunk/config.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "rubycritic/configuration"
+
 module Skunk
   # Utility module for format validation
   module FormatValidator
@@ -28,10 +30,12 @@ class Configuration
 
     def initialize
       @formats = [DEFAULT_FORMAT]
+      @root = RubyCritic::Config.root
     end
 
     def set(options = {})
       self.formats = options[:formats] if options.key?(:formats)
+      self.root = options[:root] if options.key?(:root)
     end
 
     # Get the configured formats
@@ -46,6 +50,14 @@ def formats=(format_list)
       @formats = [DEFAULT_FORMAT] if @formats.empty?
     end
 
+    def root
+      @root || File.expand_path("tmp/rubycritic", Dir.pwd)
+    end
+
+    def root=(path)
+      @root = path.nil? || path.to_s.empty? ? nil : File.expand_path(path.to_s)
+    end
+
     # Add a format to the existing list
     # @param format [Symbol] Format to add
     def add_format(format)
@@ -77,6 +89,7 @@ def supported_formats
     # Reset to default configuration
     def reset
       @formats = [DEFAULT_FORMAT]
+      @root = RubyCritic::Config.root
     end
   end
 

lib/skunk/generators/console_report.rb

@@ -2,8 +2,11 @@
 
 require "erb"
 require "terminal-table"
+require "pathname"
+require "fileutils"
 
 require "skunk/generators/console/simple"
+require "skunk/config"
 
 module Skunk
   module Generator
@@ -14,14 +17,25 @@ def initialize(analysed_modules)
       end
 
       def generate_report
-        puts generator.render
+        content = generator.render
+        puts content
+        FileUtils.mkdir_p(file_directory)
+        File.write(file_pathname, content)
       end
 
       private
 
       def generator
         @generator ||= Skunk::Generator::Console::Simple.new(@analysed_modules)
       end
+
+      def file_directory
+        @file_directory ||= Pathname.new(Skunk::Config.root)
+      end
+
+      def file_pathname
+        Pathname.new(file_directory).join("skunk_console.txt")
+      end
     end
   end
 end

lib/skunk/generators/html/overview.rb

@@ -49,6 +49,10 @@ def files
             FileData.new(module_data)
           end
         end
+
+        def root_directory
+          @root_directory ||= Pathname.new(Skunk::Config.root)
+        end
       end
     end
   end

lib/skunk/generators/json/simple.rb

@@ -2,7 +2,7 @@
 
 require "pathname"
 
-require "rubycritic/configuration"
+require "skunk/config"
 require "skunk/rubycritic/analysed_modules_collection"
 
 module Skunk
@@ -25,7 +25,7 @@ def data
         end
 
         def file_directory
-          @file_directory ||= Pathname.new(RubyCritic::Config.root)
+          @file_directory ||= Pathname.new(Skunk::Config.root)
         end
 
         def file_pathname

test/lib/skunk/cli/options/argv_test.rb

@@ -5,23 +5,21 @@
 require "skunk/cli/options/argv"
 
 describe Skunk::Cli::Options::Argv do
-  describe "#output_filename" do
-    context "passing --out=FILE options" do
-      let(:argv) { ["--out=file.txt"] }
+  describe "--out path" do
+    after do
+      Skunk::Config.reset
+    end
 
-      it "parses passed filename" do
-        parser = Skunk::Cli::Options::Argv.new(argv)
-        parser.parse
-        _(parser.output_filename).must_equal "file.txt"
-      end
+    it "sets Skunk::Config.root to the provided path" do
+      parser = Skunk::Cli::Options::Argv.new(["--out=tmp/custom"])
+      parser.parse
+      _(Skunk::Config.root).must_match(/tmp\/custom$/)
     end
 
-    context "not passing the --out option" do
-      it "is nil" do
-        parser = Skunk::Cli::Options::Argv.new([])
-        parser.parse
-        _(parser.output_filename).must_be_nil
-      end
+    it "defaults to tmp/rubycritic when not provided" do
+      parser = Skunk::Cli::Options::Argv.new([])
+      parser.parse
+      _(Skunk::Config.root).must_match(/tmp\/rubycritic$/)
     end
   end