Skip to content

Commit c1d9e7b

Browse files
committed
Removing VCR gem
1 parent cc48f1b commit c1d9e7b

5 files changed

Lines changed: 8 additions & 71 deletions

File tree

Gemfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,3 @@ gemspec
99

1010
gem "reek", "~> 6.1"
1111
gem "rubocop", "~> 1.48"
12-
gem "vcr", "~> 6.1.0"

skunk.gemspec

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ Gem::Specification.new do |spec|
3838
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
3939
spec.require_paths = ["lib"]
4040

41-
spec.add_dependency "base64", "~> 0.3.0"
4241
spec.add_dependency "rubycritic", ">= 4.5.2", "< 5.0"
4342
spec.add_dependency "terminal-table", "~> 3.0"
4443

@@ -53,5 +52,5 @@ Gem::Specification.new do |spec|
5352
spec.add_development_dependency "rubocop"
5453
spec.add_development_dependency "simplecov", "~> 0.18"
5554
spec.add_development_dependency "simplecov-console", "0.5.0"
56-
spec.add_development_dependency "webmock", "~> 3.10.0"
55+
spec.add_development_dependency "webmock", "~> 3.20.0"
5756
end

test/lib/skunk/application_test.rb

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,12 @@
7575
end
7676

7777
around do |example|
78-
VCR.use_cassette "skunk-fyi" do
79-
example.call
80-
end
78+
stub_request(:post, "https://skunk.fastruby.io/reports").to_return(
79+
status: 200,
80+
body: '{"id":"j"}',
81+
headers: { "Content-Type" => "application/json" }
82+
)
83+
example.call
8184
end
8285

8386
it "share report to default server" do

test/samples/vcr/skunk-fyi.yml

Lines changed: 0 additions & 59 deletions
This file was deleted.

test/test_helper.rb

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
require "minitest/around/spec"
2727
require "minitest/stub_any_instance"
2828
require "webmock/minitest"
29-
require "vcr"
3029

3130
require "skunk/rubycritic/analysed_module"
3231

@@ -53,8 +52,4 @@ def capture_output_streams
5352
$stderr = STDERR
5453
end
5554

56-
VCR.configure do |config|
57-
config.hook_into :webmock
58-
config.allow_http_connections_when_no_cassette = false
59-
config.cassette_library_dir = "test/samples/vcr"
60-
end
55+
WebMock.disable_net_connect!(allow_localhost: true)

0 commit comments

Comments
 (0)