Ruby 3.4 Test#125
Closed
JuanVqz wants to merge 3 commits into
Closed
Conversation
JuanVqz
commented
Oct 14, 2025
|
|
||
| gem install bundler -v "$BUNDLER_CONSTRAINT" | ||
| echo "Bundler installed: $(bundle -v)" | ||
| gem install bundler -v 2.4.22 |
Member
Author
There was a problem hiding this comment.
Update to use the latest bundler version supported at Ruby 2.6
ERROR: Error installing bundler:
The last version of bundler (>= 0) to support your Ruby & RubyGems was 2.4.22. Try installing it with `gem install bundler -v 2.4.22`
bundler requires Ruby version >= 3.2.0. The current ruby version is 2.6.10.210.
JuanVqz
commented
Oct 14, 2025
| .ruby-version | ||
| .tool-versions | ||
|
|
||
| Gemfile.lock |
Member
Author
There was a problem hiding this comment.
Ignore Gemfile.lock since we do not push it to this repo.
1 task
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Ruby 3.4 by addressing the base64 dependency requirement and simplifying the CI workflow configuration.
- Moved base64 dependency from conditional Gemfile entry to gemspec as a standard dependency
- Simplified GitHub Actions workflow by removing complex bundler version constraints
- Standardized on bundler version 2.4.22 for all Ruby versions
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| skunk.gemspec | Added base64 as a standard dependency |
| Gemfile | Removed conditional base64 dependency for Ruby 3.4+ |
| .github/workflows/main.yml | Simplified bundler installation to use fixed version 2.4.22 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
b3dd024 to
630de30
Compare
1147a2d to
c90921f
Compare
Member
Author
|
closing in favor of #124 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.