Skip to content

Ruby 3.4 Test#125

Closed
JuanVqz wants to merge 3 commits into
ruby-3-4-compatibilityfrom
ruby-3-4-test
Closed

Ruby 3.4 Test#125
JuanVqz wants to merge 3 commits into
ruby-3-4-compatibilityfrom
ruby-3-4-test

Conversation

@JuanVqz
Copy link
Copy Markdown
Member

@JuanVqz JuanVqz commented Oct 14, 2025

No description provided.


gem install bundler -v "$BUNDLER_CONSTRAINT"
echo "Bundler installed: $(bundle -v)"
gem install bundler -v 2.4.22
Copy link
Copy Markdown
Member Author

@JuanVqz JuanVqz Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to use the latest bundler version supported at Ruby 2.6

CI link

ERROR:  Error installing bundler:
	The last version of bundler (>= 0) to support your Ruby & RubyGems was 2.4.22. Try installing it with `gem install bundler -v 2.4.22`
	bundler requires Ruby version >= 3.2.0. The current ruby version is 2.6.10.210.

Comment thread .gitignore
.ruby-version
.tool-versions

Gemfile.lock
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore Gemfile.lock since we do not push it to this repo.

@JuanVqz JuanVqz requested a review from Copilot October 14, 2025 16:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Ruby 3.4 by addressing the base64 dependency requirement and simplifying the CI workflow configuration.

  • Moved base64 dependency from conditional Gemfile entry to gemspec as a standard dependency
  • Simplified GitHub Actions workflow by removing complex bundler version constraints
  • Standardized on bundler version 2.4.22 for all Ruby versions

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
skunk.gemspec Added base64 as a standard dependency
Gemfile Removed conditional base64 dependency for Ruby 3.4+
.github/workflows/main.yml Simplified bundler installation to use fixed version 2.4.22

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread skunk.gemspec Outdated
@JuanVqz
Copy link
Copy Markdown
Member Author

JuanVqz commented Oct 14, 2025

closing in favor of #124

@JuanVqz JuanVqz closed this Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants