Commit 7f254ea
Fix external change handler to only notify on actual value changes
When UserDefaults.didChangeNotification fires, the handler now reads the current
value and compares it with the cached value using shouldSetValue() before triggering
the mutation notification. This prevents unnecessary SwiftUI view re-evaluations
when unrelated properties change in UserDefaults.
Also add test to verify unrelated properties are not notified on external changes.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>1 parent c8b021c commit 7f254ea
2 files changed
Lines changed: 37 additions & 2 deletions
File tree
- Sources/ObservableDefaultsMacros/Macros
- Tests/ObservableDefaultsTests
Lines changed: 11 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
185 | | - | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
186 | 190 | | |
187 | 191 | | |
188 | 192 | | |
189 | 193 | | |
190 | | - | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
191 | 200 | | |
192 | 201 | | |
193 | 202 | | |
| |||
Lines changed: 26 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
0 commit comments