From 4d693b5cf2cdfe39286d040ca016bf48f223203f Mon Sep 17 00:00:00 2001
From: Saulo Benigno <saulo.benigno@gmail.com>
Date: Sat, 28 Mar 2026 12:26:50 -0300
Subject: [PATCH 1/5] feat(weather): allow manual latitude/longitude input

- Remove readonly attribute from latitude and longitude inputs so users can type coordinates directly without using the map picker
- Re-read coordinate inputs when opening the map modal so manually  entered values are respected; validated with Number.isFinite
- Recalculate zoom level based on whether coordinates are present, matching mini_weather behavior (4.5 if set, 2.5 if not)
- Reinitialize map view and marker position when the map is already  initialized and reopened with updated coordinates
---
 src/plugins/weather/settings.html | 39 ++++++++++++++++++++++++-------
 1 file changed, 31 insertions(+), 8 deletions(-)

diff --git a/src/plugins/weather/settings.html b/src/plugins/weather/settings.html
index 8e137ef86..3a26b2f62 100644
--- a/src/plugins/weather/settings.html
+++ b/src/plugins/weather/settings.html
@@ -5,11 +5,11 @@
     <label class="form-label">Location: </label>
     <div class="form-group">
         <span>Latitude </span>
-        <input readonly type="text" id="latitude" name="latitude" class="form-input" />
+        <input type="text" id="latitude" name="latitude" class="form-input" />
     </div>
     <div class="form-group">
         <span>Longitude </span>
-        <input readonly type="text" id="longitude" name="longitude" class="form-input" />
+        <input type="text" id="longitude" name="longitude" class="form-input" />
     </div>
     <button type="button" id="openMap" class="action-button compact">Select Location</button>
 </div>
@@ -169,16 +169,31 @@ <h2 id="modalTitle">Select Location</h2>
         const $mapModal = document.querySelector('#mapModal');
         const $closeMap = document.querySelector('#closeMap');
 
-        let latitude = +$latitude.value;
-        let longitude = +$longitude.value;
-        let zoom = latitude && longitude ? 4.5 : 2.5;
+        let latitude = Number($latitude.value) || 0;
+        let longitude = Number($longitude.value) || 0;
+        let zoom = $latitude.value && $longitude.value ? 4.5 : 2.5;
         let selectedTitle = 'location';
         let weatherProvider = 'OpenMeteo';
 
         let map, marker;
 
         $openMap.addEventListener('click', () => {
-            openModal('mapModal')
+            // Re-read the current latitude/longitude inputs in case the user
+            // edited them manually after the page loaded.
+            const latInput = document.getElementById('latitude').value;
+            const longInput = document.getElementById('longitude').value;
+            const parsedLat = Number(latInput);
+            const parsedLong = Number(longInput);
+
+            if (Number.isFinite(parsedLat) && Number.isFinite(parsedLong)) {
+                latitude = parsedLat;
+                longitude = parsedLong;
+            }
+
+            // Recompute zoom based on whether coordinates are present
+            zoom = (document.getElementById('latitude').value && document.getElementById('longitude').value) ? 4.5 : 2.5;
+
+            openModal('mapModal');
             setTimeout(() => {
                 if (!map) {
                     map = L.map('map').setView([latitude, longitude], zoom);
@@ -188,6 +203,10 @@ <h2 id="modalTitle">Select Location</h2>
                     map.on('click', event => {
                         marker.setLatLng(event.latlng);
                     });
+                } else {
+                    map.invalidateSize();
+                    map.setView([latitude, longitude], zoom);
+                    marker.setLatLng([latitude, longitude]);
                 }
             }, 100);
         });
@@ -200,8 +219,8 @@ <h2 id="modalTitle">Select Location</h2>
         });
 
         if (loadPluginSettings) {
-            document.getElementById('latitude').value = pluginSettings.latitude;
-            document.getElementById('longitude').value = pluginSettings.longitude;
+            document.getElementById('latitude').value = pluginSettings.latitude || '';
+            document.getElementById('longitude').value = pluginSettings.longitude || '';
 
             document.getElementById('units').value = pluginSettings.units;
 
@@ -255,6 +274,10 @@ <h2 id="modalTitle">Select Location</h2>
             document.getElementById('weatherTimeZone').value = "locationTimeZone";
         }
 
+        latitude = Number(document.getElementById('latitude').value) || 0;
+        longitude = Number(document.getElementById('longitude').value) || 0;
+        zoom = document.getElementById('latitude').value && document.getElementById('longitude').value ? 4.5 : 2.5;
+
         document.getElementById('weatherProvider').value = weatherProvider;
         document.querySelector(`input[name="titleSelection"][value="${selectedTitle}"]`).checked = true;
         updateTitleOptions(weatherProvider)

From ac3ee1d689c13b7fa10d3a209c7118017e2e3610 Mon Sep 17 00:00:00 2001
From: Saulo Benigno <saulo.benigno@gmail.com>
Date: Sat, 28 Mar 2026 12:48:57 -0300
Subject: [PATCH 2/5] feat(weather): enhance coordinate handling with
 validation functions

---
 src/plugins/weather/settings.html | 55 ++++++++++++++++++++++---------
 1 file changed, 40 insertions(+), 15 deletions(-)

diff --git a/src/plugins/weather/settings.html b/src/plugins/weather/settings.html
index 3a26b2f62..417144f89 100644
--- a/src/plugins/weather/settings.html
+++ b/src/plugins/weather/settings.html
@@ -117,6 +117,16 @@ <h2 id="modalTitle">Select Location</h2>
 
 <script>
 
+    /** Return true when value is a non-empty string that parses to a finite number. */
+    function hasCoord(value) {
+        return typeof value === 'string' && value.trim() !== '' && Number.isFinite(Number(value));
+    }
+
+    /** Parse a coordinate string, returning fallback when empty/invalid. */
+    function parseCoord(value, fallback) {
+        return hasCoord(value) ? Number(value) : fallback;
+    }
+
     function updateTitleOptions(provider) {
         const titleLocationRadio = document.getElementById('title-location');
         const titleLocationLabel = document.querySelector('label[for="title-location"]');
@@ -169,29 +179,36 @@ <h2 id="modalTitle">Select Location</h2>
         const $mapModal = document.querySelector('#mapModal');
         const $closeMap = document.querySelector('#closeMap');
 
-        let latitude = Number($latitude.value) || 0;
-        let longitude = Number($longitude.value) || 0;
-        let zoom = $latitude.value && $longitude.value ? 4.5 : 2.5;
+        let latitude = parseCoord($latitude.value, 0);
+        let longitude = parseCoord($longitude.value, 0);
+        let zoom = hasCoord($latitude.value) && hasCoord($longitude.value) ? 4.5 : 2.5;
         let selectedTitle = 'location';
         let weatherProvider = 'OpenMeteo';
 
         let map, marker;
+        let markerMoved = false;
+        let hadValidCoords = false;
 
         $openMap.addEventListener('click', () => {
             // Re-read the current latitude/longitude inputs in case the user
             // edited them manually after the page loaded.
             const latInput = document.getElementById('latitude').value;
             const longInput = document.getElementById('longitude').value;
-            const parsedLat = Number(latInput);
-            const parsedLong = Number(longInput);
 
-            if (Number.isFinite(parsedLat) && Number.isFinite(parsedLong)) {
-                latitude = parsedLat;
-                longitude = parsedLong;
+            hadValidCoords = hasCoord(latInput) && hasCoord(longInput);
+            markerMoved = false;
+
+            if (hadValidCoords) {
+                const parsedLat = Number(latInput);
+                const parsedLong = Number(longInput);
+                if (Number.isFinite(parsedLat) && Number.isFinite(parsedLong)) {
+                    latitude = parsedLat;
+                    longitude = parsedLong;
+                }
             }
 
             // Recompute zoom based on whether coordinates are present
-            zoom = (document.getElementById('latitude').value && document.getElementById('longitude').value) ? 4.5 : 2.5;
+            zoom = hadValidCoords ? 4.5 : 2.5;
 
             openModal('mapModal');
             setTimeout(() => {
@@ -202,6 +219,10 @@ <h2 id="modalTitle">Select Location</h2>
 
                     map.on('click', event => {
                         marker.setLatLng(event.latlng);
+                        markerMoved = true;
+                    });
+                    marker.on('dragend', () => {
+                        markerMoved = true;
                     });
                 } else {
                     map.invalidateSize();
@@ -212,9 +233,13 @@ <h2 id="modalTitle">Select Location</h2>
         });
 
         $closeMap.addEventListener('click', () => {
-            const position = marker.getLatLng().wrap();
-            $latitude.value = position.lat;
-            $longitude.value = position.lng;
+            // Only persist coordinates if the user moved the marker
+            // or the inputs already had valid values before opening.
+            if (markerMoved || hadValidCoords) {
+                const position = marker.getLatLng().wrap();
+                $latitude.value = position.lat;
+                $longitude.value = position.lng;
+            }
             closeModal('mapModal');
         });
 
@@ -274,9 +299,9 @@ <h2 id="modalTitle">Select Location</h2>
             document.getElementById('weatherTimeZone').value = "locationTimeZone";
         }
 
-        latitude = Number(document.getElementById('latitude').value) || 0;
-        longitude = Number(document.getElementById('longitude').value) || 0;
-        zoom = document.getElementById('latitude').value && document.getElementById('longitude').value ? 4.5 : 2.5;
+        latitude = parseCoord(document.getElementById('latitude').value, 0);
+        longitude = parseCoord(document.getElementById('longitude').value, 0);
+        zoom = hasCoord(document.getElementById('latitude').value) && hasCoord(document.getElementById('longitude').value) ? 4.5 : 2.5;
 
         document.getElementById('weatherProvider').value = weatherProvider;
         document.querySelector(`input[name="titleSelection"][value="${selectedTitle}"]`).checked = true;

From fd35312fcafa4463056c7770e029e193df2357cd Mon Sep 17 00:00:00 2001
From: Saulo Benigno <saulo.benigno@gmail.com>
Date: Sat, 28 Mar 2026 12:51:08 -0300
Subject: [PATCH 3/5] feat(weather): validate manual latitude and longitude
 input

---
 src/plugins/weather/weather.py | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/plugins/weather/weather.py b/src/plugins/weather/weather.py
index e5d829e83..e67b07c3d 100644
--- a/src/plugins/weather/weather.py
+++ b/src/plugins/weather/weather.py
@@ -72,10 +72,15 @@ def generate_settings_template(self):
         return template_params
 
     def generate_image(self, settings, device_config):
-        lat = float(settings.get('latitude'))
-        long = float(settings.get('longitude'))
-        if not lat or not long:
+        raw_lat = settings.get('latitude', '').strip()
+        raw_long = settings.get('longitude', '').strip()
+        if not raw_lat or not raw_long:
             raise RuntimeError("Latitude and Longitude are required.")
+        try:
+            lat = float(raw_lat)
+            long = float(raw_long)
+        except (ValueError, TypeError):
+            raise RuntimeError("Latitude and Longitude must be valid numbers.")
 
         units = settings.get('units')
         if not units or units not in ['metric', 'imperial', 'standard']:

From 81902781b209a2e953c58eeb86de726a6299bead Mon Sep 17 00:00:00 2001
From: Saulo Benigno <saulo.benigno@gmail.com>
Date: Sat, 28 Mar 2026 12:53:39 -0300
Subject: [PATCH 4/5] fix(weather): use nullish coalescing for latitude and
 longitude defaults

---
 src/plugins/weather/settings.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/plugins/weather/settings.html b/src/plugins/weather/settings.html
index 417144f89..66f0b8f0b 100644
--- a/src/plugins/weather/settings.html
+++ b/src/plugins/weather/settings.html
@@ -244,8 +244,8 @@ <h2 id="modalTitle">Select Location</h2>
         });
 
         if (loadPluginSettings) {
-            document.getElementById('latitude').value = pluginSettings.latitude || '';
-            document.getElementById('longitude').value = pluginSettings.longitude || '';
+            document.getElementById('latitude').value = pluginSettings.latitude ?? '';
+            document.getElementById('longitude').value = pluginSettings.longitude ?? '';
 
             document.getElementById('units').value = pluginSettings.units;
 

From 7c42e66011e4b8cbd05e8625301761278df502f8 Mon Sep 17 00:00:00 2001
From: Saulo Benigno <saulo.benigno@gmail.com>
Date: Sat, 28 Mar 2026 13:05:57 -0300
Subject: [PATCH 5/5] feat(weather): add validation for manual latitude and
 longitude inputs

---
 src/plugins/weather/settings.html | 38 +++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/src/plugins/weather/settings.html b/src/plugins/weather/settings.html
index 66f0b8f0b..64f508165 100644
--- a/src/plugins/weather/settings.html
+++ b/src/plugins/weather/settings.html
@@ -127,6 +127,40 @@ <h2 id="modalTitle">Select Location</h2>
         return hasCoord(value) ? Number(value) : fallback;
     }
 
+    /** Validate lat/long inputs. Returns true if valid or both empty. */
+    function validateCoordInputs() {
+        const latVal = document.getElementById('latitude').value.trim();
+        const longVal = document.getElementById('longitude').value.trim();
+
+        // Both empty is fine (no location set yet)
+        if (latVal === '' && longVal === '') {
+            return true;
+        }
+
+        if (latVal === '' || longVal === '') {
+            showResponseModal('failure', 'Error! Both latitude and longitude are required.');
+            return false;
+        }
+
+        if (!hasCoord(latVal) || !hasCoord(longVal)) {
+            showResponseModal('failure', 'Error! Latitude and longitude must be valid numbers.');
+            return false;
+        }
+
+        const lat = Number(latVal);
+        const long = Number(longVal);
+        if (lat < -90 || lat > 90) {
+            showResponseModal('failure', 'Error! Latitude must be between -90 and 90.');
+            return false;
+        }
+        if (long < -180 || long > 180) {
+            showResponseModal('failure', 'Error! Longitude must be between -180 and 180.');
+            return false;
+        }
+
+        return true;
+    }
+
     function updateTitleOptions(provider) {
         const titleLocationRadio = document.getElementById('title-location');
         const titleLocationLabel = document.querySelector('label[for="title-location"]');
@@ -189,7 +223,11 @@ <h2 id="modalTitle">Select Location</h2>
         let markerMoved = false;
         let hadValidCoords = false;
 
+        // Register global validation hook so handleAction can call it
+        window.pluginValidate = validateCoordInputs;
+
         $openMap.addEventListener('click', () => {
+            if (!validateCoordInputs()) return;
             // Re-read the current latitude/longitude inputs in case the user
             // edited them manually after the page loaded.
             const latInput = document.getElementById('latitude').value;