Fix init() crash on Waveshare grayscale displays (epd3in7)#724
Open
cycsmail wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #525.
Some Waveshare drivers like epd3in7 take a required
modeargument oninit()and render through mode-specific methods (Clear(color, mode)/display_1Gray) instead of the genericdisplay(), soinit()was raisingTypeError: EPD.init() missing 1 required positional argument: 'mode'.This detects that case from the driver's
initsignature and drives those panels in 1Gray (monochrome) mode, which lines up with the existing single-color path. Standard mono and bi-color displays are untouched.Added tests for the epd3in7 init/display path plus a regression check that standard mono displays are unaffected. The new tests pass (3 passed) and the existing suite stays green (28 passed).