Skip to content

Commit afde9ef

Browse files
authored
Traffic analyzer standalone entry (#848)
1 parent 2f6d23a commit afde9ef

11 files changed

Lines changed: 304 additions & 79 deletions

File tree

daq/acl_state_collector.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,11 @@ def _get_port_rule_counts(self, switch, port, acl_config, rule_samples):
4141
acl_config._id, rule_config.get('description'))
4242
continue
4343

44+
rule_description = rule_config.get('description')
45+
if not rule_description:
46+
LOGGER.error('Rule with cookie %s does not have a description', cookie_num)
47+
continue
48+
4449
has_sample = False
4550
for sample in rule_samples:
4651
if str(sample.labels.get('cookie')) != str(cookie_num):
@@ -49,14 +54,15 @@ def _get_port_rule_counts(self, switch, port, acl_config, rule_samples):
4954
continue
5055
if int(sample.labels.get('in_port')) != port:
5156
continue
52-
rule_map = rules_map.setdefault(rule_config['description'], {})
57+
58+
rule_map = rules_map.setdefault(rule_description, {})
5359
rule_map['packet_count'] = int(sample.value)
5460
has_sample = True
5561
break
5662

5763
if not has_sample:
5864
error = (f'No ACL metric sample available for switch, port, ACL, rule: '
59-
f'{switch}, {port}, {acl_config._id}, {rule_config["description"]} '
65+
f'{switch}, {port}, {acl_config._id}, {rule_description} '
6066
f'(cookie={cookie_num})')
6167
errors.append(error)
6268
LOGGER.error(error)

daq/entry.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -100,13 +100,6 @@ def _stripped_alt_logger(self, level, msg, *args, **kwargs):
100100
ALT_LOG._log(level, stripped, *args, **kwargs)
101101

102102

103-
def _write_pid_file():
104-
pid = os.getpid()
105-
LOGGER.info('pid is %d', pid)
106-
with open(_PID_FILE, 'w') as pid_file:
107-
pid_file.write(str(pid))
108-
109-
110103
def _execute():
111104
daq = DAQ(sys.argv)
112105
configurator.print_config(daq.config)
@@ -120,7 +113,7 @@ def _execute():
120113
if not daq.validate_config():
121114
return 1
122115

123-
_write_pid_file()
116+
utils.write_pid_file(_PID_FILE, LOGGER)
124117

125118
signal.signal(signal.SIGINT, signal.default_int_handler)
126119
signal.signal(signal.SIGTERM, signal.default_int_handler)

daq/proto/acl_counting_pb2.py

Lines changed: 41 additions & 34 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)