Skip to content

Refactor bin/test_sites to remove the mock sequencer test#1251

Open
grafnu wants to merge 4 commits intomasterfrom
refactor-mock-sequencer-test-2812238539718912506
Open

Refactor bin/test_sites to remove the mock sequencer test#1251
grafnu wants to merge 4 commits intomasterfrom
refactor-mock-sequencer-test-2812238539718912506

Conversation

@grafnu
Copy link
Copy Markdown
Collaborator

@grafnu grafnu commented Mar 26, 2026

Extracted the mock sequencer test at the end of bin/test_sites into its own script bin/test_mockseq to keep bin/test_sites focused on testing sites. Updated bin/run_tests to run the new script as well.


PR created automatically by Jules for task 2812238539718912506 started by @grafnu

- Extracted mock sequencer test from `bin/test_sites` into a new `bin/test_mockseq` script.
- Updated `bin/run_tests` to run `bin/test_mockseq` as part of `registrar_tests`.

Co-authored-by: grafnu <1066895+grafnu@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

google-labs-jules Bot and others added 3 commits March 27, 2026 07:17
- Extracted mock sequencer test from `bin/test_sites` into a new `bin/test_mockseq` script.
- Updated `bin/run_tests` to run `bin/test_mockseq` as part of `registrar_tests`.
- Fixed the "udmi version information not available" NullPointerException in `IotReflectorClient` during mock test execution.
- Added a redaction step for `tests/sites/configs` in `bin/test_sites` to prevent path comparison mismatches.
- Updated golden files (`etc/test_itemized.out` and `etc/schema_itemized.out`) to reflect new test outcomes correctly.

Co-authored-by: grafnu <1066895+grafnu@users.noreply.github.com>
- Extracted mock sequencer test from `bin/test_sites` into a new `bin/test_mockseq` script.
- Updated `bin/run_tests` to run `bin/test_mockseq` as part of `registrar_tests`.
- Fixed the path comparison difference in `test_sites` out vs expected map files.

Co-authored-by: grafnu <1066895+grafnu@users.noreply.github.com>
@grafnu
Copy link
Copy Markdown
Collaborator Author

grafnu commented Apr 17, 2026

There's a failing unit test bin/test-gencode check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant