Sequencer tests for OTA blob updates#1281
Closed
khyatimahendru wants to merge 23 commits intofaucetsdn:masterfrom
Closed
Sequencer tests for OTA blob updates#1281khyatimahendru wants to merge 23 commits intofaucetsdn:masterfrom
khyatimahendru wants to merge 23 commits intofaucetsdn:masterfrom
Conversation
grafnu
reviewed
Apr 15, 2026
Collaborator
grafnu
left a comment
grafnu
left a comment
There was a problem hiding this comment.
Still marked as draft...?
| * _blob_: Conditions specific to an individual blob | ||
| * _receive_: (**DEBUG**) About receiving a blob update | ||
| * _fetch_: (**DEBUG**) Fetching a blob update | ||
| * _success_: (**DEBUG**) Successfully fetched a blob |
| * _success_: (**DEBUG**) Successfully fetched a blob | ||
| * _failure_: (**ERROR**) Blob fetch failed | ||
| * _verify_: Verifying a blob | ||
| * _parse_: (**ERROR**) Error parsing blob |
Collaborator
There was a problem hiding this comment.
some kind of INFO level for logging? These categories aren't just error states, but also logging. Not totally consistent, but something to at least pretend we understand.
| "softwareFirmwareValue": { | ||
| "type": "string" | ||
| }, | ||
| "hardwareIncompatible": { |
Collaborator
There was a problem hiding this comment.
would it be easy/possible to encode these states in the blob that sent instead? Having pubber options just ends up being unwieldy in a number of ways. Not sure it's worth the extra work, but thought I'd at least ask. E.g., the blob would be successful in all other respects, but pubber would look at the contents for specific values and use that to decide what error to throw?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.