fix tests

Author: fayedraza1234

.secrets.baseline

@@ -90,6 +90,10 @@
     {
       "path": "detect_secrets.filters.allowlist.is_line_allowlisted"
     },
+    {
+      "path": "detect_secrets.filters.common.is_baseline_file",
+      "filename": ".secrets.baseline"
+    },
     {
       "path": "detect_secrets.filters.common.is_ignored_due_to_verification_policies",
       "min_level": 2
@@ -145,7 +149,7 @@
         "filename": "auth_platform/auth_platform/auth_service/auth.py",
         "hashed_secret": "c3d3a05a92ff2b63e27aa3e0cd0bc32ff36be9c6",
         "is_verified": false,
-        "line_number": 6
+        "line_number": 7
       }
     ],
     "auth_platform/auth_platform_tests/test_2fa.py": [
@@ -199,5 +203,5 @@
       }
     ]
   },
-  "generated_at": "2025-11-17T00:44:04Z"
+  "generated_at": "2025-11-17T00:58:14Z"
 }

auth_platform/auth_platform/auth_service/auth.py

@@ -2,6 +2,7 @@
 from datetime import datetime, timedelta
 import jwt
 from sqlalchemy.orm import Session
+from .models import TOTPAttempt
 
 SECRET_KEY = "change-this-secret-in-prod"
 ALGORITHM = "HS256"
@@ -34,16 +35,17 @@ def check_rate_limit(user_id: int, db: Session) -> tuple[bool, int]:
         - is_rate_limited: True if user has exceeded 5 failed attempts in 15 minutes
         - minutes_until_reset: Minutes until rate limit resets (0 if not limited)
     """
-    from .models import TOTPAttempt
-
     # Calculate time window (15 minutes ago)
     time_window = datetime.utcnow() - timedelta(minutes=15)
 
+    # Refresh session to get latest data
+    db.expire_all()
+
     # Query failed attempts within the time window
     failed_attempts = db.query(TOTPAttempt).filter(
         TOTPAttempt.user_id == user_id,
         TOTPAttempt.attempted_at > time_window,
-        TOTPAttempt.success is False
+        TOTPAttempt.success == False  # pylint: disable=singleton-comparison
     ).order_by(TOTPAttempt.attempted_at.asc()).all()
 
     # Check if rate limit exceeded
@@ -69,8 +71,6 @@ def record_totp_attempt(user_id: int, success: bool, db: Session) -> None:
         success: Whether the verification was successful
         db: Database session
     """
-    from .models import TOTPAttempt
-
     attempt = TOTPAttempt(
         user_id=user_id,
         success=success,

auth_platform/auth_platform/auth_service/db.py

@@ -1,4 +1,4 @@
-from sqlalchemy import create_engine, Index
+from sqlalchemy import create_engine, Index, inspect
 from sqlalchemy.ext.declarative import declarative_base
 from sqlalchemy.orm import sessionmaker
 from sqlalchemy.exc import SQLAlchemyError
@@ -13,13 +13,17 @@ def init_db():
     Base.metadata.create_all(bind=engine)
 
     # Create index for TOTP attempts if not exists
-    from .models import TOTPAttempt
-    idx = Index('idx_totp_attempts_user_time', TOTPAttempt.user_id, TOTPAttempt.attempted_at)
-    try:
-        idx.create(bind=engine, checkfirst=True)
-    except SQLAlchemyError:
-        # Index may already exist
-        pass
+    from .models import TOTPAttempt  # Import here to avoid circular dependency
+    inspector = inspect(engine)
+    existing_indexes = [idx['name'] for idx in inspector.get_indexes('totp_attempts')]
+
+    if 'idx_totp_attempts_user_time' not in existing_indexes:
+        idx = Index('idx_totp_attempts_user_time', TOTPAttempt.user_id, TOTPAttempt.attempted_at)
+        try:
+            idx.create(bind=engine)
+        except SQLAlchemyError:
+            # Index may already exist (race condition)
+            pass
 
 def get_db():
     db = SessionLocal()