Release/3.1.0#198
Merged
Merged
Conversation
Release v3.0.0
…do, referência da API e exemplos de uso
Release/v3.0.1
Ajusta a importação e a chamada da função de compilação de regex para melhorar a legibilidade e a consistência do código.
…retrizes e ferramentas Implementa dois novos agentes com foco em boas práticas de programação e planejamento de testes. O Pythonic Guardian segue o Zen of Python e Clean Code, enquanto o QA Sentinel se concentra em análise estática e cobertura de testes.
…o DateTime Inclui testes para verificar a funcionalidade de comparação de datas, incluindo casos de datas válidas, iguais, inválidas e limites de intervalo.
Adiciona a função _to_date para garantir que comparações entre instâncias de date e datetime não gerem TypeError. Atualiza os testes para validar o comportamento esperado sem erros.
…ção de data Ajusta a formatação das funções de teste para melhorar a legibilidade e a consistência do código.
…ção de data Ajusta a formatação das funções de teste para seguir as convenções de estilo e melhorar a legibilidade.
…os testes Atualiza os testes para garantir que as comparações entre tipos de data e datetime considerem corretamente a informação de fuso horário, melhorando a precisão das validações de data.
|
Keep this PR in a mergeable state → Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements version 3.1.0 of the PyFlunt library, introducing new validation contracts for dates/times, URLs, numeric values, and Brazilian documents (CPF/CNPJ). The main focus of the visible changes is on improving the DateTimeValidationContract to properly handle mixed date/datetime comparisons and adding comprehensive test coverage, along with new AI agent configurations for automated testing workflows.
Key changes:
- Enhanced date/datetime validation with type normalization helper to prevent TypeError when comparing date and datetime objects
- Comprehensive test suite for datetime validations covering edge cases and type mixing scenarios
- Code formatting improvements and explicit import style for better maintainability
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/validations/test_datetime_validation_contract.py | New comprehensive test suite (373 lines) covering all datetime validation methods with happy paths, boundary conditions, None handling, and date/datetime type mixing scenarios |
| flunt/validations/datetime_validation_contract.py | Added _to_date() helper function for safe date/datetime normalization; refactored is_date_after, is_date_before, and is_date_between methods to use the helper for consistent type handling |
| flunt/validations/url_validation_contract.py | Improved import style by explicitly importing compile and IGNORECASE from re module instead of importing re and using qualified names |
| samples/flunt_sample.py | Code formatting adjustment to comply with line-length=79 Ruff configuration (joined multi-line logger.info call) |
| .gitignore | Added .serena/cache/ directory to ignore list for AI agent tooling cache |
| .github/agents/qa-sentinel.agent.md | New AI agent configuration for test planning and quality assurance workflows (contains invalid model identifier) |
| .github/agents/pythonic-guardian.agent.md | New AI agent configuration for Python code implementation following PEP 20 and Clean Code principles (contains invalid model identifier) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descrição
Mudanças Propostas
Checklist de Revisão
Comentários Adicionais (opcional)
Issue Relacionada
Closes #<numero_da_issue>