Fix for Python 3.14+ not having pkg_resources#66
Open
blepping wants to merge 1 commit intofbcotter:masterfrom
Open
Fix for Python 3.14+ not having pkg_resources#66blepping wants to merge 1 commit intofbcotter:masterfrom
blepping wants to merge 1 commit intofbcotter:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.14 removed the pkg_resources package (it had been deprecated for a while). It seems like
importlib_resourcesis the generally accepted replacement. This small change usesimportlib_resourcesif it's available and falls back to to tryingpkg_resources. I wouldn't normally just blind catchExceptionbut it seems like the best option to make sure there's as little chance as possible that this change breaks anything.Conversion to
importlib_resourcesis pretty straightforward: https://importlib-resources.readthedocs.io/en/latest/migration.html#pkg-resources-resource-streamThe import could also be done the other way around, trying
pkg_resourcesfirst if you prefer.