merge: sync thesuperhackers upstream (06-19-2026)

[fbraz3]

Description

Sync from TheSuperHackers upstream (10 commits from main branch)

Merged Changes

• AI: Guard mode behavior fix when attacked (bugfix(ai): Fix bugged unit behavior when attacked during guard mode TheSuperHackers/GeneralsGameCode#2197)
• Network: CRC mismatch fix for disconnected players (bugfix(crc): Fix spurious mismatches for disconnected players at low CRC intervals TheSuperHackers/GeneralsGameCode#2796), command ID overflow ordering (bugfix(network): Improve compare method of command id's to keep network commands in chronological order when overflowing TheSuperHackers/GeneralsGameCode#2736)
• Pathfinder: Accurate single-unit movement destinations (bugfix(pathfinder): Fix inaccurate single unit movement destinations when unobstructed TheSuperHackers/GeneralsGameCode#2296)
• Texture loader: Refactor, simplified code, fixed reduction bugs, lifted 1:8 aspect ratio limit (bugfix(textureloader): Lift hardcoded texture aspect ratio limit of 1:8 to allow loading all textures with modern gpu TheSuperHackers/GeneralsGameCode#2788, bugfix(textureloader): Fix faulty texture reduction implementations TheSuperHackers/GeneralsGameCode#2789)
• Performance: 90% faster label lookup in Waypoint/PolygonTrigger (perf: Reduce cost of retrieving labels from Waypoint and PolygonTrigger by 90% TheSuperHackers/GeneralsGameCode#2761)
• Refactor: SelectionXlat unification (unify(selectionxlat): Merge SelectionXlat TheSuperHackers/GeneralsGameCode#2792)

Conflict Resolution

Only 1 file had conflicts: Core/Libraries/Source/WWVegas/WW3D2/textureloader.cpp

Resolution strategy:

• Preserved GeneralsX headless null checks (Texture, DX8 caps, D3DTexture)
• Adopted upstream variable renames for consistency
• Dropped redundant MipLevelCount assignment (made obsolete by upstream refactor)

Validation

Platform	Configure	Build
macOS (arm64)	✅ OK	✅ OK (GeneralsXZH + GeneralsX)
Linux (x86_64)	✅ OK	⚠️ Pre-existing DXVK header issue (not caused by merge)

Testing Checklist

• Game launch (ZH and Generals)
• Main menu navigation
• Skirmish gameplay (especially single-unit movement)
• Campaign flow
• Audio/video playback
• Renderer stability (texture loader changes)
• Multiplayer: long sessions and player disconnect scenarios
• AI guard behavior under attack
• Mod loading

Risky Areas

• textureloader.cpp — upstream refactor was extensive
• AIPathfind.cpp — new RETAIL_COMPATIBLE_PATHFINDING guard
• GameLogic.cpp — CRC validation now skips disconnected players
• NetCommandList.cpp — command ID overflow handling changed