fix(network): correctly map PlayerIndex to SlotIndex in CRC validation#189
Open
fbraz3 wants to merge 5 commits into
Open
fix(network): correctly map PlayerIndex to SlotIndex in CRC validation#189fbraz3 wants to merge 5 commits into
fbraz3 wants to merge 5 commits into
Conversation
A previous commit (14/06/2026) introduced a regression where TheNetwork->isPlayerConnected was incorrectly passed a PlayerIndex instead of a SlotIndex. This caused the loop to skip CRC validation for all players, allowing matches to desync silently without triggering the Mismatch UI. This fix resolves the slot index dynamically by matching the player's display name, restoring the intended behavior.
fbraz3
force-pushed
the
fix/crc-validation-bypass
branch
from
8ca70df to
aaaf717
Compare
fbraz3
force-pushed
the
fix/crc-validation-bypass
branch
from
a55c224 to
abc3292
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(network): correctly map PlayerIndex to SlotIndex in CRC validation
A previous commit (14/06/2026) introduced a regression where
TheNetwork->isPlayerConnected was incorrectly passed a PlayerIndex
instead of a SlotIndex. This caused the loop to skip CRC validation
for all players, allowing matches to desync silently without triggering
the Mismatch UI.
This fix resolves the slot index dynamically by matching the player's
display name, restoring the intended behavior.