appium: font (#373)

Author: eagleoflqj

appium/test_font.py

@@ -0,0 +1,50 @@
+from appium.webdriver.webdriver import WebDriver
+from util.button import get_label
+from util.config import read_theme_config
+from util.message import ASSUMPTION_OUTDATED, CHANGE_NOT_SAVED, UI_NOT_UPDATED
+from util.window import find_element_by_id, find_elements_by_id, open_theme_config
+
+TEXT_FONT_FAMILY_ID = "TextFontFamily"
+FONT_HELVETICA = "Helvetica"
+FONT_SERIF = "serif"
+FONT_EMOJI = "Apple Color Emoji"
+
+
+def test_font_selection(driver: WebDriver, app: str):
+    open_theme_config(driver)
+    find_element_by_id(driver, "Font").click()
+
+    def get_font_values() -> list[str]:
+        return [
+            get_label(element)
+            for element in find_elements_by_id(driver, TEXT_FONT_FAMILY_ID)
+        ]
+
+    def read_config_value() -> dict[str, str]:
+        return read_theme_config(app)[f"Font/{TEXT_FONT_FAMILY_ID}"]
+
+    font_button = find_element_by_id(driver, TEXT_FONT_FAMILY_ID)
+    font_button.click()
+    emoji_elements = find_elements_by_id(driver, FONT_EMOJI)
+    assert len(emoji_elements) == 1, ASSUMPTION_OUTDATED
+
+    search = find_element_by_id(driver, "search")
+    search.click()
+    search.send_keys("helvetica")
+    emoji_elements = find_elements_by_id(driver, FONT_EMOJI)
+    assert len(emoji_elements) == 0, UI_NOT_UPDATED
+
+    find_element_by_id(driver, FONT_HELVETICA).click()
+    find_element_by_id(driver, "select").click()
+    assert get_font_values() == [FONT_HELVETICA], UI_NOT_UPDATED
+    assert read_config_value() == {"0": FONT_HELVETICA}, CHANGE_NOT_SAVED
+
+    find_element_by_id(driver, f"{TEXT_FONT_FAMILY_ID}_plus").click()
+    find_elements_by_id(driver, TEXT_FONT_FAMILY_ID)[1].click()
+    find_element_by_id(driver, "GenericFontFamiliesTab").click()
+    find_element_by_id(driver, FONT_SERIF).click()
+    find_element_by_id(driver, "select").click()
+    assert get_font_values() == [FONT_HELVETICA, FONT_SERIF], UI_NOT_UPDATED
+    assert read_config_value() == {"0": FONT_HELVETICA, "1": FONT_SERIF}, (
+        CHANGE_NOT_SAVED
+    )

appium/test_key.py

@@ -1,8 +1,8 @@
 from appium.webdriver.webdriver import WebDriver
 from selenium.webdriver.common.keys import Keys
-from util.button import get_undo_redo
+from util.button import get_label, get_undo_redo
 from util.config import read_global_config
-from util.key import get_label, press
+from util.key import press
 from util.message import (
     BUTTON_SHOULD_BE_DISABLED,
     BUTTON_SHOULD_BE_ENABLED,

appium/test_list.py

@@ -1,9 +1,8 @@
 from appium.webdriver.webdriver import WebDriver
-from util.button import get_undo_redo
+from util.button import get_label, get_undo_redo
 from util.config import read_config, read_global_config
 from util.enum import get_enum_value, select_enum_option
-from util.key import get_label
-from util.list import click_minus, click_plus
+from util.list import click_minus, click_plus, click_up
 from util.message import (
     ASSUMPTION_OUTDATED,
     BUTTON_SHOULD_BE_DISABLED,
@@ -80,6 +79,14 @@ def read_config_value() -> dict[str, str]:
     assert get_provider_values() == provider_values, UI_NOT_UPDATED
     assert read_config_value() == config_after_minus, CHANGE_NOT_SAVED
 
+    click_up(driver, PROVIDER_ORDER, 1)
+    provider_values.reverse()
+    assert get_provider_values() == provider_values, UI_NOT_UPDATED
+    assert read_config_value() == {
+        "0": config_after_minus["1"],
+        "1": config_after_minus["0"],
+    }, CHANGE_NOT_SAVED
+
 
 def test_clear_list_and_reset(driver: WebDriver, app: str):
     def count() -> int:

appium/util/button.py

@@ -13,3 +13,8 @@ def get_undo_redo(driver: WebDriver) -> tuple[WebElement, WebElement]:
     assert redo.is_enabled() is False, BUTTON_SHOULD_BE_DISABLED
 
     return undo, redo
+
+
+def get_label(button: WebElement) -> str:
+    """Get the label attribute of a button."""
+    return button.get_attribute("label")

appium/util/color.py

@@ -1,6 +1,7 @@
 from appium.webdriver.common.appiumby import AppiumBy
 from selenium.webdriver.common.keys import Keys
 from selenium.webdriver.remote.webelement import WebElement
+from util.button import get_label
 from util.key import press
 from util.window import find_element_by_id
 
@@ -20,7 +21,7 @@ def set_color_value(element: WebElement, value: str):
     # Slider mode
     buttons = driver.find_elements(AppiumBy.CLASS_NAME, "XCUIElementTypeButton")
     for button in buttons:
-        if button.get_attribute("label") == "Color Sliders":
+        if get_label(button) == "Color Sliders":
             button.click()
             break
 

appium/util/key.py

@@ -1,6 +1,5 @@
 from appium.webdriver.webdriver import WebDriver
 from selenium.webdriver.common.actions.action_builder import ActionBuilder
-from selenium.webdriver.remote.webelement import WebElement
 
 
 def press(driver: WebDriver, keys: list[str]):
@@ -10,7 +9,3 @@ def press(driver: WebDriver, keys: list[str]):
     for key in reversed(keys):
         action.key_action.key_up(key)
     action.perform()
-
-
-def get_label(button: WebElement) -> str:
-    return button.get_attribute("label")

appium/util/list.py

@@ -2,9 +2,17 @@
 from util.window import find_element_by_id
 
 
+def _click(driver: WebDriver, option_id: str, index: int, action: str):
+    find_element_by_id(driver, f"{option_id}_{index}_{action}").click()
+
+
 def click_minus(driver: WebDriver, option_id: str, index: int):
-    find_element_by_id(driver, f"{option_id}_{index}_minus").click()
+    _click(driver, option_id, index, "minus")
 
 
 def click_plus(driver: WebDriver, option_id: str, index: int):
-    find_element_by_id(driver, f"{option_id}_{index}_plus").click()
+    _click(driver, option_id, index, "plus")
+
+
+def click_up(driver: WebDriver, option_id: str, index: int):
+    _click(driver, option_id, index, "up")

src/config/FontView.swift

@@ -58,11 +58,13 @@ struct FontView: OptionViewProtocol {
           Text(localize(font))
         }
       }
+      .accessibilityIdentifier(data["Option"] as? String ?? "")
       .sheet(isPresented: $selectorIsOpen) {
         VStack {
           TabView {
             VStack {
               TextField(NSLocalizedString("Search", comment: ""), text: $searchInput)
+                .accessibilityIdentifier("search")
               TextField(NSLocalizedString("Preview", comment: ""), text: $previewInput)
               Text(previewInput).font(Font.custom(selectedFontFamily ?? font, size: 32)).frame(
                 height: 64)
@@ -73,27 +75,36 @@ struct FontView: OptionViewProtocol {
                     Spacer()
                     Text(localize(family))
                   }
+                  .accessibilityElement(children: .combine)
+                  .accessibilityIdentifier(family)
                 }
               }.contextMenu(forSelectionType: String.self) { items in
               } primaryAction: { items in
                 // Double click
                 select()
               }
             }.padding()
-              .tabItem { Text("Font family") }
+              .tabItem {
+                Text("Font family")
+                  .accessibilityIdentifier("FontFamilyTab")
+              }
 
             VStack {
               List(selection: $selectedFontFamily) {
                 ForEach(genericFamilies, id: \.self) { family in
                   Text(family)
+                    .accessibilityIdentifier(family)
                 }
               }.contextMenu(forSelectionType: String.self) { items in
               } primaryAction: { items in
                 // Double click
                 select()
               }
             }.padding()
-              .tabItem { Text("Generic font families") }
+              .tabItem {
+                Text("Generic font families")
+                  .accessibilityIdentifier("GenericFontFamiliesTab")
+              }
           }
 
           HStack {
@@ -102,13 +113,16 @@ struct FontView: OptionViewProtocol {
             } label: {
               Text("Cancel")
             }
+            .accessibilityIdentifier("cancel")
             Spacer()
             Button {
               select()
             } label: {
               Text("Select")
-            }.buttonStyle(.borderedProminent)
-              .disabled(selectedFontFamily == nil)
+            }
+            .accessibilityIdentifier("select")
+            .buttonStyle(.borderedProminent)
+            .disabled(selectedFontFamily == nil)
           }.padding([.leading, .trailing, .bottom])
         }
         .padding(.top)