appium: reset group#368
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the macOS Config UI and Appium test suite to support testing “reset group” behavior in an input method’s configuration by exposing additional accessibility identifiers and adding a dedicated Appium test with a deterministic starting profile.
Changes:
- Added accessibility identifiers for input method list entries and the detail ScrollView in the Input Methods config UI.
- Added an Appium helper to open Input Methods config and select a specific IM.
- Added a new Appium test for resetting a config group, plus a fixed
profilethat’s copied into each test’s config home.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/config/InputMethod.swift | Adds accessibility identifiers needed for Appium to select an IM and locate the detail ScrollView. |
| appium/util/window.py | Adds open_input_method_config() helper used by tests. |
| appium/test_group.py | New test verifying “reset group” behavior (UI + persisted config). |
| appium/profile | Provides a stable initial fcitx profile with a default group and pinyin enabled. |
| appium/conftest.py | Copies the test profile into each per-test config home before launching the app. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arm64 comparisonNo difference. x86_64 comparisonNo difference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.