fix list clear and reset#369
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves list-option UI behavior and Appium testability by adding stable accessibility identifiers to list controls and extending the Appium test suite to cover list operations (remove/add/undo/redo) and clear+reset scenarios.
Changes:
- Add per-row and per-list accessibility identifiers for ListView buttons (up/minus/plus).
- Adjust ListView state refresh logic on external
valuechanges. - Add Appium helpers and new tests for list behavior; improve assertion messages in an existing key test.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/config/ListView.swift |
Adds accessibility identifiers for list action buttons and modifies list state refresh logic via onChange. |
appium/util/message.py |
Introduces additional standardized assertion messages for tests. |
appium/util/list.py |
Adds Appium helper functions to click list minus/plus buttons by accessibility id. |
appium/test_list.py |
Adds new Appium tests covering list add/remove, undo/redo, and clear+reset behavior. |
appium/test_key.py |
Improves test assertions by attaching clearer failure messages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arm64 comparisonNo difference. x86_64 comparisonNo difference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.