appim: optimize parse config#370
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR optimizes per-application default input method selection in the macOS frontend by parsing the AppDefaultIM config once during updateConfig() and caching the result for quick lookup during focus changes.
Changes:
- Added an
appDefaultIMCache_map to storeappId -> imNamederived fromAppDefaultIM. - Populated/cleared the cache during
MacosFrontend::updateConfig()instead of parsing JSON on everyfocusIn. - Simplified
useAppDefaultIM()to a hash-map lookup and IM switch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| macosfrontend/macosfrontend.h | Adds a new member cache (std::unordered_map) to store parsed app default IM mappings. |
| macosfrontend/macosfrontend.cpp | Builds the cache in updateConfig() and uses it in useAppDefaultIM() to avoid repeated JSON parsing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arm64 comparisonNo difference. x86_64 comparisonNo difference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.