fix: font weight stepper delta=100#372
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the configuration UI behavior for font-weight integer options so that the stepper changes values in 100-point “weight” steps (while still supporting arbitrary numeric input), and adds UI tests to cover the updated behavior.
Changes:
- Added a
FontWeightdescription annotation to font-weight config options so the Swift UI can detect them. - Updated
IntegerViewstepper increment/decrement logic to round font-weight changes to the next/previous 100 boundary. - Expanded Appium coverage with a non-numeric input validation check and a dedicated font-weight stepping test.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
webpanel/webpanel.h |
Introduces FontWeightAnnotation and applies it to font weight options so the UI can treat them specially. |
src/config/IntegerView.swift |
Implements font-weight-aware stepping logic (rounded 100-step changes) and reuses the same logic for button-based steppers. |
appium/test_integer.py |
Adds regression tests for non-numeric integer input handling and for font-weight stepper behavior (100-step rounding/clamping). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arm64 comparisonNo difference. x86_64 comparisonNo difference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.