fix: punctuation map tab/click blur due to rerender (related bd223d0)#374
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses focus loss/blur in the punctuation map editor caused by SwiftUI re-renders, and extends the Appium UI test suite to cover the punctuation map tab/focus behavior.
Changes:
- Avoid unnecessary
ListViewstate updates when the serialized list content hasn’t changed (to prevent focus resets). - Add an accessibility identifier to an
ExternalViewgear button to improve UI testability. - Add Appium helpers (scrolling, focus detection), update existing tests/fixtures, and add a new punctuation map Appium test.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/config/ListView.swift | Adds a guard to skip list state updates when config value changes are semantically identical. |
| src/config/ExternalView.swift | Adds an accessibility identifier to the default external-config gear button. |
| appium/util/window.py | Adds a reusable scroll helper for macOS Appium tests. |
| appium/util/string.py | Adds a helper to detect focus state on elements. |
| appium/util/button.py | Switches undo/redo lookup to use find_elements_by_id. |
| appium/test_group.py | Refactors inline scrolling to use the new scroll helper. |
| appium/test_entry.py | Adds an Appium test validating punctuation map focus/tab behavior and persistence. |
| appium/conftest.py | Introduces per-test config/data directories and injects FCITX_DATA_HOME for tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arm64 comparisonNo difference. x86_64 comparisonNo difference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.