Support HiDPI theme images with @2x/@3x variants#1528
Open
gaoxiaoliangz wants to merge 1 commit intofcitx:masterfrom
Open
Support HiDPI theme images with @2x/@3x variants#1528gaoxiaoliangz wants to merge 1 commit intofcitx:masterfrom
gaoxiaoliangz wants to merge 1 commit intofcitx:masterfrom
Conversation
Resolve fcitx#1215 - Auto-detect @2x/@3x image variants (e.g. panel@2x.png) for 9-patch background images, using cairo_surface_set_device_scale for proper source sampling - Remove the intermediate logical-resolution surface in Theme::paint() so 9-patch renders directly on the scaled cairo context - Margin values remain in 1x logical pixels; source image cropping is automatically scaled by the device scale factor
|
👀 |
wengxt
requested changes
Mar 17, 2026
|
|
||
| void Theme::paint(cairo_t *c, const BackgroundImageConfig &cfg, int width, | ||
| int height, double alpha, double scale) { | ||
| int height, double alpha, double /*scale*/) { |
Member
There was a problem hiding this comment.
Image should be using the closest scale, instead of fixed one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #1215