chore: use isolated declarations

Author: fczbkk

eslint.config.js

@@ -26,4 +26,9 @@ export default [
     files: ["**/*.js"],
     ...tseslint.configs.disableTypeChecked,
   },
+  {
+    rules: {
+      "@typescript-eslint/no-inferrable-types": "off",
+    },
+  },
 ];

src/constants.ts

@@ -1,24 +1,24 @@
-import { CSS_SELECTOR_TYPE } from "./types.js";
+import { CSS_SELECTOR_TYPE, CssSelectorType } from "./types.js";
 
 export const SELECTOR_SEPARATOR = ", ";
 
 // RegExp that will match invalid patterns that can be used in ID attribute.
-export const INVALID_ID_RE = new RegExp(
+export const INVALID_ID_RE: RegExp = new RegExp(
   [
     "^$", // empty or not set
     "\\s", // contains whitespace
   ].join("|"),
 );
 
 // RegExp that will match invalid patterns that can be used in class attribute.
-export const INVALID_CLASS_RE = new RegExp(
+export const INVALID_CLASS_RE: RegExp = new RegExp(
   [
     "^$", // empty or not set
   ].join("|"),
 );
 
 // Order in which a combined selector is constructed.
-export const SELECTOR_PATTERN = [
+export const SELECTOR_PATTERN: CssSelectorType[] = [
   CSS_SELECTOR_TYPE.nthoftype,
   CSS_SELECTOR_TYPE.tag,
   CSS_SELECTOR_TYPE.id,

src/selector-attribute.ts

@@ -1,14 +1,14 @@
 import { sanitizeSelectorItem } from "./utilities-selectors.js";
 import { createPatternMatcher, getIntersection } from "./utilities-data.js";
-import { CssSelectorGenerated } from "./types.js";
+import { CssSelectorGenerated, PatternMatcher } from "./types.js";
 
 interface AttributeData {
   name: string;
   value: string;
 }
 
 // List of attributes to be ignored. These are handled by different selector types.
-export const attributeBlacklistMatch = createPatternMatcher([
+export const attributeBlacklistMatch: PatternMatcher = createPatternMatcher([
   "class",
   "id",
   // Angular attributes

src/utilities-selectors.ts

@@ -35,11 +35,11 @@ import { isElement } from "./utilities-iselement.js";
 import { getPowerSet, powerSetGenerator } from "./utilities-powerset.js";
 import { cartesianProductGenerator } from "./utilities-cartesian.js";
 
-export const ESCAPED_COLON = ":".charCodeAt(0).toString(16).toUpperCase();
+export const ESCAPED_COLON: string = ":".charCodeAt(0).toString(16).toUpperCase();
 
 // Square brackets need to be escaped, but eslint has a problem with that.
 /* eslint-disable-next-line no-useless-escape */
-export const SPECIAL_CHARACTERS_RE = /[ !"#$%&'()\[\]{|}<>*+,./;=?@^`~\\]/;
+export const SPECIAL_CHARACTERS_RE: RegExp = /[ !"#$%&'()\[\]{|}<>*+,./;=?@^`~\\]/;
 
 /**
  * Escapes special characters used by CSS selector items.
@@ -354,7 +354,7 @@ function* candidatesGenerator(
 export function* selectorWithinRootGenerator(
   elements: Element[],
   root: ParentNode,
-  rootSelector: CssSelector = "",
+  rootSelector: CssSelector | undefined = "",
   options: CssSelectorGeneratorOptions,
 ): IterableIterator<CssSelector, undefined> {
   const elementSelectorsIterator = allSelectorsGenerator(elements, options);
@@ -375,7 +375,7 @@ export function* selectorWithinRootGenerator(
 export function* closestIdentifiableParentGenerator(
   elements: Element[],
   root: ParentNode,
-  rootSelector: CssSelector = "",
+  rootSelector: CssSelector | undefined = "",
   options: CssSelectorGeneratorOptions,
 ): IterableIterator<IdentifiableParent> {
   if (elements.length === 0) {

src/utilities.ts

@@ -34,7 +34,7 @@ export function getCommonParent(needle: Element[]): Element | null {
 /**
  * Yields all common parents of the needle, starting with the one closest to the needle.
  */
-export function* parentsGenerator(needle: Element[], root?: ParentNode) {
+export function* parentsGenerator(needle: Element[], root?: ParentNode): Generator<Element, void, unknown> {
   let parent = getCommonParent(needle);
   while (parent && root?.contains(parent)) {
     yield parent;
@@ -49,7 +49,7 @@ export function* viableParentsGenerator(
   needle: Element[],
   needleSelector: string,
   root?: ParentNode,
-) {
+): Generator<Element, void, unknown> {
   for (const parentCandidate of parentsGenerator(needle, root)) {
     if (testSelector(needle, needleSelector, parentCandidate)) {
       yield parentCandidate;

tsconfig.base.json

@@ -5,11 +5,11 @@
     "noImplicitAny": true,
     "module": "es6",
     "target": "es6",
-    "allowJs": true,
     "sourceMap": true,
     "moduleResolution": "node",
     "lib": ["ES6", "DOM", "DOM.Iterable"],
     "strict": true,
-    "erasableSyntaxOnly": true
+    "erasableSyntaxOnly": true,
+    "isolatedDeclarations": true
   }
 }